Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24657

JsonBean representation of metrics at /jmx endpoint now quotes all numbers

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.0, 1.6.0, 1.3.6, 1.4.11
    • Fix Version/s: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.2.6
    • Component/s: metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBASE-20571 had a fix to look for NaN or Infinity in numbers, and to quote those as strings. The order of the `if-else` block is different in branch-1 (https://github.com/apache/hbase/commit/2d493556f3c8ae87fb92422b525bf7c9345e6ccd) and branch-2 (https://github.com/apache/hbase/commit/39ea1efa885e2f27f41af59228e0a12c4ded08f8)

      HBASE-23015 changed the JsonBean.java code in a meaningful way, and the order of the changes were consistent between branch-1 (https://github.com/apache/hbase/commit/f77c14d18150f55ee892f8d24a5ee231c1ae7e20#diff-87e9e2722b9210eebfd8c820c5d72a46L319-L324) and branch-2 (https://github.com/apache/hbase/commit/761aef6d9d0b8a455842de4d5eac7d9486f00633#diff-2c8f5dd222141c69112c5c5b5f70cf55R319-R324) Unfortunately, they need to be reversed since the order is different between branch-1 and branch-2.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dmanning David Manning
                Reporter:
                dmanning David Manning
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: