Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24326

Removal from streamReaders can be done in finally

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.1.6
    • Fix Version/s: 2.1.10
    • Component/s: regionserver
    • Labels:
      None

      Description

      As part of the fix for https://issues.apache.org/jira/browse/HBASE-21551 we removed the storeReaders from the set inside the try block.
      The code there seems to catch IOException. But if you drill down and see how the actual readers are closed - FSDataInputStreamWrapper#close() uses IOUtils.closeQuietly where we swallow the IOException (So ideally IOException will not be thrown). But there are cases we endup getting other type of RuntimeExceptions which may fail the close() and we endup not removing the storeReader from the Set. So it is safe to always remove it in finally.

        Attachments

          Activity

            People

            • Assignee:
              mohapatra.sambit Sambit Mohapatra
              Reporter:
              ram_krish ramkrishna.s.vasudevan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: