Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We know that META splitting doesn't work correctly in 0.20, eg HBASE-1852 and others. Granted, META will only split for very big tables, but we should just explicitly disable splitting of this region.

      1. hbase-2415.txt
        0.9 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          Pretty trivial patch. I think this is the right way to go about it? It seems to have worked in my testing.

          Show
          Todd Lipcon added a comment - Pretty trivial patch. I think this is the right way to go about it? It seems to have worked in my testing.
          Hide
          Jonathan Gray added a comment -

          The patch looks good but this code changes in my patch for HBASE-2375. Will keep open so it doesn't get squashed.

          Show
          Jonathan Gray added a comment - The patch looks good but this code changes in my patch for HBASE-2375 . Will keep open so it doesn't get squashed.
          Hide
          stack added a comment -

          Jon: I want to commit this. Are you suggesting no?

          Show
          stack added a comment - Jon: I want to commit this. Are you suggesting no?
          Hide
          Todd Lipcon added a comment -

          IMO we may as well commit it, I'll make a note to double check HBASE-2375's patch to make sure it's maintained. But it sounds like that patch is a bigger change so not a candidate for this upcoming release, whereas we might as well get this simple fix in.

          Show
          Todd Lipcon added a comment - IMO we may as well commit it, I'll make a note to double check HBASE-2375 's patch to make sure it's maintained. But it sounds like that patch is a bigger change so not a candidate for this upcoming release, whereas we might as well get this simple fix in.
          Hide
          Jonathan Gray added a comment -

          Issues are linked so I won't forget. Just commit.

          We could add a unit test to make sure we prevent a regression? I'm okay w/o just an idea, the change is simple.

          Show
          Jonathan Gray added a comment - Issues are linked so I won't forget. Just commit. We could add a unit test to make sure we prevent a regression? I'm okay w/o just an idea, the change is simple.
          Hide
          stack added a comment -

          Committed to branch and branch of branch. Thanks for patch Todd.

          Show
          stack added a comment - Committed to branch and branch of branch. Thanks for patch Todd.
          Hide
          stack added a comment -

          I forwarded ported this to TRUNK.

          Show
          stack added a comment - I forwarded ported this to TRUNK.

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development