[HBASE-24070] Master async shutdown rpc call may not complete

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: master
• Assignee: Unassigned
• Reporter: Michael Stack
• Created: 27/Mar/20 19:22
• Updated: 13/May/20 23:33

Description

Debugging the parent issue and discussion over in the adjacent test fix issue HBASE-24052 and in its PR exposes a problem calling shutdown asynchronously. The shutdown runs inline with the rpc call which should change (as suggested by bharathv). Quoting from a Bharath comment in the the HBASE-24052 PR:

I think internally it is masking the problem of "shutdown()" implementation being synchronous on the server side. Ideally, I'd think it should be async on the server side too, meaning the rpc call just sets a flag (startShuttingDown = true) which is read by multiple running threads and they begin the tear down rather than doing it in the context of the rpc thread. We already do this partially but the main driver of master shutdown still runs in the rpc context.

Issue Links

• is related to: HBASE-23836 Race condition in Master startup can ignore shutdown RPC