[HBASE-24065] Enable SpotBugs in PreCommit

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 3.0.0-alpha-1, 2.3.0
• Component/s: build, test
• Assignee: Nick Dimiduk
• Reporter: Nick Dimiduk
• Created: 26/Mar/20 17:28
• Updated: 27/Mar/20 19:05
• Resolved: 27/Mar/20 16:57

Description

Yetus's SpotBugs module depends on maven_add_install. In Jenkinsfile_GitHub, I'm pretty strict on my module definitions, with

GENERAL_CHECK_PLUGINS = 'all,-compile,-javac,-javadoc,-jira,-shadedjars,-unit'
JDK_SPECIFIC_PLUGINS = 'compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit'

The general check requests all but omits compile and maven, which I think means the spotbugs check gets dropped. Before HBASE-23767, we had just a single yetus that did all, so spotbugs would have been run.

Issue Links

• is caused by: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
• is duplicated by: HBASE-22383 github PR integration for qabot needs spotbugs/findbugs
• is related to: HBASE-23077 move entirely to spotbugs
• links to: GitHub Pull Request #1364