[HBASE-23825] Increment proto conversion is broken

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.4.0, 1.2.6, 1.3.2, 1.4.1, 1.5.0, 1.1.11, 1.3.3, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.3.2.1, 1.4.6, 1.4.8, 1.4.7, 1.4.9, 1.4.10, 1.3.4, 1.3.5, 1.3.6, 1.4.11, 1.4.12
• Fix Version/s: 1.6.0, 1.3.7, 1.4.13
• Component/s: Increment
• Hadoop Flags: Reviewed
• Assignee: Abhishek Singh Chouhan
• Reporter: Abhishek Singh Chouhan
• Created: 10/Feb/20 22:14
• Updated: 12/Feb/20 23:53
• Resolved: 12/Feb/20 01:18

Description

While converting the request back to Increment using ProtobufUtil.toIncrement we incorrectly use the optimization to avoid copying the byte array(HBaseZeroCopyByteString#zeroCopyGetBytes) on a BoundedByteString. The optimization was only meant for LiteralByteString where it is safe to use the backing byte array, however it ends up being used to BoundedByteString which is a subclass of LiteralByteString. This essentially breaks increments since we end up creating wrong cells on the server side. 

Issue Links

• blocks: HBASE-23220 Release 1.6.0
• blocks: HBASE-23743 Release 1.4.13
• is broken by: HBASE-18026 ProtobufUtil seems to do extra array copying
• links to: GitHub Pull Request #1161