[HBASE-23628] Replace Apache Commons Digest Base64 with JDK8 Base64 - ASF JIRA

XML

Word

Printable

JSON

Release Note:

Hide
From the PR:

"Yes. The two create the same output... I just wrote a small test suite to increase my confidence on that. I generated many tens of millions of random byte patterns and compared the output of the two algorithms. They came back identical every time.

"Just in case any inquiring minds would like to know, there is no longer an encoding required when generating the strings. The JDK implementation specifically specifies that strings returned are StandardCharsets.ISO_8859_1. This does not change anything because UTF8 and ISO_8859 overlap for the limited character set (64 characters) the encoding uses."

Show
From the PR: "Yes. The two create the same output... I just wrote a small test suite to increase my confidence on that. I generated many tens of millions of random byte patterns and compared the output of the two algorithms. They came back identical every time. "Just in case any inquiring minds would like to know, there is no longer an encoding required when generating the strings. The JDK implementation specifically specifies that strings returned are StandardCharsets.ISO_8859_1. This does not change anything because UTF8 and ISO_8859 overlap for the limited character set (64 characters) the encoding uses."

Use the native JDK Base64 implementation instead. Most places are using the JDK version, but a couple of spots were missed.

links to

GitHub Pull Request #977