Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23374

ExclusiveMemHFileBlock’s allocator should not be hardcoded as ByteBuffAllocator.HEAP

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.3.0
    • None
    • None
    • Reviewed

    Description

      ExclusiveMemHFileBlock's constructor looks like this:

      ExclusiveMemHFileBlock(BlockType blockType, int onDiskSizeWithoutHeader,
            int uncompressedSizeWithoutHeader, long prevBlockOffset, ByteBuff buf, boolean fillHeader,
            long offset, int nextBlockOnDiskSize, int onDiskDataSizeWithHeader,
            HFileContext fileContext) {
          super(blockType, onDiskSizeWithoutHeader, uncompressedSizeWithoutHeader, prevBlockOffset, buf,
              fillHeader, offset, nextBlockOnDiskSize, onDiskDataSizeWithHeader, fileContext,
              ByteBuffAllocator.HEAP);
        }
      

      After HBASE-22802, ExclusiveMemHFileBlock’s data may be allocated through the BB pool, so it’s allocator should not be hard coded as ByteBuffAllocator.HEAP

      Attachments

        Issue Links

          Activity

            People

              javaman_chen chenxu
              javaman_chen chenxu
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: