Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23306

Add sanity check for Admin#deleteTables and other operations

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Not A Bug
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Admin
    • Labels:
      None
    • Tags:
      question, HBase-Admin,

      Description

      Description:

      After taking a brief observation, It seems to be the following operation behaves in the opposite manner of what they should be doing in case `null argument.

      For example: `Admin#listTables(Pattern)` If its argument is `null` then all the tables would be returned. Also this very method is being used by rest of the listed operation like `deleteTables()`, `enableTables()`, `disableTables()` etc.

      Affected operation:

      • Admin.listTables(Pattern)
      • Admin.listTableNames(Pattern)
      • Admin.deleteTables(Pattern)
      • Admin.enableTables(Pattern)
      • Admin.disableTables(Pattern)

      This could be a very rare scenario but I think it should either throw an exception or behave opposite of what current behavior is.

      If this was not intentional then I can quickly put together a patch with precondition check for these operations.

       

      Note: I tried to look for answers but I was not able to find any relevant issue/comments hence logging this issue. Feel free to close if this is intentional behavior.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              RahulKesharwani Rahul Kesharwani
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: