[HBASE-23250] Log message about CleanerChore delegate initialization should be at INFO

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
• Component/s: master, Operability
• Labels: beginner
• Hadoop Flags: Reviewed
• Release Note: CleanerChore delegate initialization is now logged at INFO level instead of DEBUG
• Assignee: Rabi Kumar K C
• Reporter: Sean Busbey
• Created: 04/Nov/19 18:57
• Updated: 07/Nov/19 00:56
• Resolved: 05/Nov/19 20:02

Description

Right now we log a DEBUG message as we initialize the delegates that decide on cleaner decisions:

2019-10-30 07:30:01,594 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner
2019-10-30 07:30:01,597 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotLogCleaner
2019-10-30 07:30:01,600 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.cleaner.HFileLinkCleaner
2019-10-30 07:30:01,601 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner
2019-10-30 07:30:01,602 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner

Done here in CleanerChore.java:

 private void initCleanerChain(String confKey) {
    this.cleanersChain = new LinkedList<>();
    String[] logCleaners = conf.getStrings(confKey);
    if (logCleaners != null) {
      for (String className : logCleaners) {
        T logCleaner = newFileCleaner(className, conf);
        if (logCleaner != null) {
          LOG.debug("Initialize cleaner={}", className);
          this.cleanersChain.add(logCleaner);
        }
      }
    }
  }

This message should be at INFO. it doesn't happen often and knowing what plugins decide about file deletions is important all the time.

Issue Links

• links to: GitHub Pull Request #795