Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23250

Log message about CleanerChore delegate initialization should be at INFO

    XMLWordPrintableJSON

Details

    • Reviewed
    • CleanerChore delegate initialization is now logged at INFO level instead of DEBUG

    Description

      Right now we log a DEBUG message as we initialize the delegates that decide on cleaner decisions:

      2019-10-30 07:30:01,594 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner
      2019-10-30 07:30:01,597 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotLogCleaner
      2019-10-30 07:30:01,600 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.cleaner.HFileLinkCleaner
      2019-10-30 07:30:01,601 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner
      2019-10-30 07:30:01,602 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize cleaner=org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner
      

      Done here in CleanerChore.java:

       private void initCleanerChain(String confKey) {
          this.cleanersChain = new LinkedList<>();
          String[] logCleaners = conf.getStrings(confKey);
          if (logCleaners != null) {
            for (String className : logCleaners) {
              T logCleaner = newFileCleaner(className, conf);
              if (logCleaner != null) {
                LOG.debug("Initialize cleaner={}", className);
                this.cleanersChain.add(logCleaner);
              }
            }
          }
        }
      

      This message should be at INFO. it doesn't happen often and knowing what plugins decide about file deletions is important all the time.

      Attachments

        Issue Links

          Activity

            People

              rabikumar.kc Rabi Kumar K C
              busbey Sean Busbey
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: