[HBASE-23245] All MutableHistogram implementations should remove maxExpected

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.3.0, 1.6.0
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 1.6.0, 1.4.12, 2.1.8, 2.2.3
• Component/s: metrics
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 02/Nov/19 12:07
• Updated: 16/Sep/20 20:36
• Resolved: 12/Nov/19 23:06

Description

MutableHistogram is using HistogramImpl() and not using maxExpected. From all implementation classes, maxExpected should be removed as constructor argument. Also, HistogramImpl() should pass long casting for Integer.MAX_VALUE << 2 else it is treated as -4

Issue Links

• breaks: HBASE-25052 FastLongHistogram#getCountAtOrBelow method is broken.
• links to: GitHub Pull Request #787
• links to: GitHub Pull Request #818