Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23234

Provide .editorconfig based on checkstyle configuration

    XMLWordPrintableJSON

Details

    • Hide
      Adds a .editorconfig file with configurations populated by IntelliJ, based on our checkstyle configuration. There's lots of IntelliJ-specific configs in here that I assume are not replicated to Eclipse or Netbeans users. Any devs using those tools should push whatever updates they see fit, but please start with the checkstyle configs as the origin of truth.
      Show
      Adds a .editorconfig file with configurations populated by IntelliJ, based on our checkstyle configuration. There's lots of IntelliJ-specific configs in here that I assume are not replicated to Eclipse or Netbeans users. Any devs using those tools should push whatever updates they see fit, but please start with the checkstyle configs as the origin of truth.

    Description

      I don't have an exhaustive analysis of the issue, but there's at least one case where check style plugin configuration disagrees with our settings in dev-support/hbase_eclipse_formatter.xml.

      Formatter settings produce this code chunk

            uncaughtExceptionHandler =
                (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
      

      but check style wants

            uncaughtExceptionHandler =
              (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
      

      Attachments

        Activity

          People

            ndimiduk Nick Dimiduk
            ndimiduk Nick Dimiduk
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: