[HBASE-23231] ReplicationSource do not update metrics after refresh

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.2
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.1.8, 2.2.3
• Component/s: wal
• Hadoop Flags: Reviewed
• Assignee: Lijin Bin
• Reporter: Lijin Bin
• Created: 30/Oct/19 09:24
• Updated: 04/Nov/22 05:59
• Resolved: 31/Oct/19 07:28

Description

When replication refresh to new state, it will create a new source and terminate the old source and replace the old source with new source.

  public void refreshSources(String peerId) throws IOException {
    String terminateMessage = "Peer " + peerId +
      " state or config changed. Will close the previous replication source and open a new one";
    ReplicationPeer peer = replicationPeers.getPeer(peerId);
    ReplicationSourceInterface src = createSource(peerId, peer);
    // synchronized on latestPaths to avoid missing the new log
    synchronized (this.latestPaths) {
      ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
      if (toRemove != null) {
        LOG.info("Terminate replication source for " + toRemove.getPeerId());
        toRemove.terminate(terminateMessage);
      }
      for (NavigableSet<String> walsByGroup : walsById.get(peerId).values()) {
        walsByGroup.forEach(wal -> src.enqueueLog(new Path(this.logDir, wal)));
      }
    }
    LOG.info("Startup replication source for " + src.getPeerId());
    src.startup();

terminate replication source will remove all metrics, current terminate replication source be called after create new source which do init metrics, so the result is there is no corresponding metrics after refresh replication source.

Issue Links

• is a parent of: HBASE-24781 Clean up peer metrics when disabling peer
• is related to: HBASE-27463 Reset sizeOfLogQueue when refresh replication source
• links to: GitHub Pull Request #778