[HBASE-23202] ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 1.5.0, 2.2.1, 1.4.11, 2.1.7
• Fix Version/s: 3.0.0-alpha-1, 2.3.0
• Component/s: snapshots
• Assignee: Guangxu Cheng
• Reporter: Zach York
• Created: 23/Oct/19 01:16
• Updated: 21/Jun/20 15:27
• Resolved: 09/Jun/20 05:56

Description

HBASE-17330 removed the checking of the snapshot .tmp directory when determining which files are candidates for deletes. It appears that in the latest branches, this isn't an issue for taking a snapshot as it checks whether a snapshot is in progress via the SnapshotManager.

However, when using the ExportSnapshot tool to import a snapshot into a cluster, it will first copy the snapshot manifest into /.snapshot/.tmp/<snapshot> [1], copies the files, and then renames the snapshot manifest to the final snapshot directory. If the copyFiles job takes longer than the cleaner TTL, the ExportSnapshot job will fail because HFiles will get deleted before the snapshot is committed to the final directory.

The ExportSnapshot tool already has a functionality to skipTmp and write the manifest directly to the final location. However, this has unintended consequences such as the snapshot appearing to the user before it is usable. So it looks like we will have to bring back the tmp directory check to avoid this situation.

[1] https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java#L1029

Issue Links

• is cloned by: HBASE-24442 Test coverage for HBASE-23202 - ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL
• is related to: HBASE-24522 consolidate TestSnapshotFileCacheWithDifferentWorkingDir and TestSnapshotFileCache by parameterized test.
• is related to: HBASE-21511 Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles
• links to: GitHub Pull Request #769
• links to: GitHub Pull Request #1791
• links to: GitHub Pull Request #1873
• links to: GitHub Pull Request #1874
• links to: GitHub Pull Request #1875
• links to: GitHub Pull Request #1876