Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22933

Do not need to kick reassign for rs group change any more

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0, 2.3.0, 2.2.1
    • Component/s: rsgroup
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The old implementation is a bit strange, the isStuck method is like this:

        public boolean isStuck() {
          return isInState(State.FAILED_OPEN) && getProcedure() != null;
        }
      

      It can only return true when there are ongoing procedures. But if we have a procedure, then the procedure will try to reassign region. Scheduling a new procedure does not make sense here, at least for branch-2.2+.

      I suggest we just remove the related code, since the default retry number for assigning a region is Integer.MAX_VALUE. And even if user set this to small value and finally the region is left in FAILED_OPEN state without a procedure, HBCK2 is used to deal with this, it is not necessary to deal it automatically.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                zhangduo Duo Zhang
                Reporter:
                zhangduo Duo Zhang
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: