[HBASE-22611] hbase-common module's class "org.apache.hadoop.hbase.io.encoding.RowIndexCodecV1" DataOutputStream is not closed.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.4, 2.1.5
• Fix Version/s: 3.0.0-alpha-1
• Component/s: io
• Hadoop Flags: Reviewed
• Assignee: yuliangwan
• Reporter: yuliangwan
• Created: 20/Jun/19 09:14
• Updated: 25/Jun/19 02:03
• Resolved: 24/Jun/19 21:16

Description

 

public ByteBuffer decodeKeyValues(DataInputStream source,
HFileBlockDecodingContext decodingCtx) throws IOException{...}

DataOutputStream is not close after use.

//代码占位符
else {
  RowIndexSeekerV1 seeker = new RowIndexSeekerV1(CellComparatorImpl.COMPARATOR,
      decodingCtx);
  seeker.setCurrentBuffer(new SingleByteBuff(sourceAsBuffer));
  List<Cell> kvs = new ArrayList<>();
  kvs.add(seeker.getCell());
  while (seeker.next()) {
    kvs.add(seeker.getCell());
  }
  boolean includesMvcc = decodingCtx.getHFileContext().isIncludesMvcc();
  ByteArrayOutputStream baos = new ByteArrayOutputStream();
  DataOutputStream out = new DataOutputStream(baos);
  for (Cell cell : kvs) {
    KeyValue currentCell = KeyValueUtil.copyToNewKeyValue(cell);
    out.write(currentCell.getBuffer(), currentCell.getOffset(),
        currentCell.getLength());
    if (includesMvcc) {
      WritableUtils.writeVLong(out, cell.getSequenceId());
    }
  }
  out.flush();
  return ByteBuffer.wrap(baos.getBuffer(), 0, baos.size());
}

 

 

Issue Links

• links to: GitHub Pull Request #325