Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22972 [JDK11] Support JDK11 LTS in HBase
  3. HBASE-22585

Ensure javax.annotation doesn't get include in shaded artifacts when built with Java 11

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.3.0
    • build, java

    Description

      Master & branch-2 build fails on Java 11. Complaints about the hbase-shaded-check-invariants. Will paste the stacktrace if needed in the comments. 

      Attachments

        Issue Links

          Activity

            sakthi Sakthi added a comment -

            Fails both on master & branch-2

            sakthi Sakthi added a comment - Fails both on master & branch-2
            sakthi Sakthi added a comment -

            With the patch in place, the build passes on both Java 11 & 8 on both branches.

            sakthi Sakthi added a comment - With the patch in place, the build passes on both Java 11 & 8 on both branches.
            HBaseQA HBase QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 59s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -0 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  master Compile Tests
            0 mvndep 0m 21s Maven dependency ordering for branch
            +1 mvninstall 6m 2s master passed
            +1 compile 0m 45s master passed
            +1 shadedjars 5m 40s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 0m 26s master passed
                  Patch Compile Tests
            0 mvndep 0m 13s Maven dependency ordering for patch
            +1 mvninstall 5m 22s the patch passed
            +1 compile 0m 43s the patch passed
            +1 javac 0m 43s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 3s The patch has no ill-formed XML file.
            +1 shadedjars 5m 36s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 16m 25s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
            +1 javadoc 0m 27s the patch passed
                  Other Tests
            +1 unit 0m 27s hbase-shaded in the patch passed.
            +1 unit 0m 16s hbase-shaded-client in the patch passed.
            +1 asflicense 0m 23s The patch does not generate ASF License warnings.
            50m 25s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-HBASE-Build/541/artifact/patchprocess/Dockerfile
            JIRA Issue HBASE-22585
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12971824/hbase-22585.master.001.patch
            Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
            uname Linux e50e9633b62f 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
            Build tool maven
            Personality dev-support/hbase-personality.sh
            git revision master / ab4453158a
            maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
            Default Java 1.8.0_181
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/541/testReport/
            Max. process+thread count 85 (vs. ulimit of 10000)
            modules C: hbase-shaded hbase-shaded/hbase-shaded-client U: hbase-shaded
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/541/console
            Powered by Apache Yetus 0.9.0 http://yetus.apache.org

            This message was automatically generated.

            HBaseQA HBase QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 59s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -0 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 6m 2s master passed +1 compile 0m 45s master passed +1 shadedjars 5m 40s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 26s master passed       Patch Compile Tests 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 5m 22s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 shadedjars 5m 36s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 16m 25s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. +1 javadoc 0m 27s the patch passed       Other Tests +1 unit 0m 27s hbase-shaded in the patch passed. +1 unit 0m 16s hbase-shaded-client in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 50m 25s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-HBASE-Build/541/artifact/patchprocess/Dockerfile JIRA Issue HBASE-22585 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12971824/hbase-22585.master.001.patch Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile uname Linux e50e9633b62f 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux Build tool maven Personality dev-support/hbase-personality.sh git revision master / ab4453158a maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) Default Java 1.8.0_181 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/541/testReport/ Max. process+thread count 85 (vs. ulimit of 10000) modules C: hbase-shaded hbase-shaded/hbase-shaded-client U: hbase-shaded Console output https://builds.apache.org/job/PreCommit-HBASE-Build/541/console Powered by Apache Yetus 0.9.0 http://yetus.apache.org This message was automatically generated.
            busbey Sean Busbey added a comment -

            thanks for this Sakthi!

            busbey Sean Busbey added a comment - thanks for this Sakthi!
            sakthi Sakthi added a comment -

            Thanks for pushing this in Sean.

            sakthi Sakthi added a comment - Thanks for pushing this in Sean.
            hudson Hudson added a comment -

            Results for branch master
            build #1157 on builds.a.o: -1 overall


            details (if available):

            +1 general checks
            – For more information see general report

            +1 jdk8 hadoop2 checks
            – For more information see jdk8 (hadoop2) report

            -1 jdk8 hadoop3 checks
            – For more information see jdk8 (hadoop3) report

            +1 source release artifact
            – See build output for details.

            +1 client integration test

            hudson Hudson added a comment - Results for branch master build #1157 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report +1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test
            hudson Hudson added a comment -

            Results for branch branch-2
            build #2010 on builds.a.o: -1 overall


            details (if available):

            +1 general checks
            – For more information see general report

            +1 jdk8 hadoop2 checks
            – For more information see jdk8 (hadoop2) report

            -1 jdk8 hadoop3 checks
            – For more information see jdk8 (hadoop3) report

            +1 source release artifact
            – See build output for details.

            +1 client integration test

            hudson Hudson added a comment - Results for branch branch-2 build #2010 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report +1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test

            People

              sakthi Sakthi
              sakthi Sakthi
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: