[HBASE-22340] Corrupt KeyValue is silently ignored

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.2, 2.0.4
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.0.6, 2.1.5
• Component/s: wal
• Assignee: Peter Somogyi
• Reporter: Peter Somogyi
• Created: 30/Apr/19 09:51
• Updated: 02/May/19 19:05
• Resolved: 02/May/19 09:44

Description

When a KeyValue is constructed from a corrupt byte array then IllegalArgumentException is thrown with a detailed message where the issue is in the array. This is part of a sanity check introduced in HBASE-21401.
However, this is not logged at this time and the exception goes up to ProtobufLogReader.readNext where it is caught, wrapped into EOFException and the processing of the current WAL file is stopped.
There is only a TRACE level log message that could indicate if something went wrong.

This will cause data loss without log message not just for the single corrupted KV but for the rest of the WAL file.

Issue Links

• links to: GitHub Pull Request #207