Assigning Nicolas since he's doing the work (Made N a contributor).
@Nicolas, a few comments and solicitation of opinon.
+ We need to update the hadoop we bundle. We'll want to ship with hadoop 0.20.2. It has at a minimum hdfs-127 fix. We should probably apply hdfs-826 to the hadoop we ship too since its a client-side only change. If we included hdfs-200, that'd make it so this test you've included actually gets exercised so we should apply it too?
+ In fact, it looks like this test fails if 826 and 200 are not in place, is that right? You probably don't want that. Maybe skip out the test if they are not in place but don't fail I'd say.
+ Your test is great.
+ FYI, we try not to reference log4j explicitly. – i.e. the logger implementation – but i think in this case you have no choice going by the commons dictum that the logger config. is outside of its scope (I was reading under "Configuring the Underlying Logging System" in http://commons.apache.org/logging/apidocs/org/apache/commons/logging/package-summary.html).
+ I like the comments you've added to HLog.java
+ The log message says hadoop-4379 if hdfs-200 is found... maybe add or change mention of hdfs-200
Patch looks good otherwise.