[HBASE-22137] [hbase-thirdparty] RC0 doesn't include google.protobuf so fails PB generation if you try to use it.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: thirdparty-2.2.0
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 30/Mar/19 19:51
• Updated: 19/Sep/23 07:51
• Resolved: 30/Mar/19 20:10

Description

Tried to use the RC0. Build failed with this sort of stuff:

[INFO] --- protobuf-maven-plugin:0.5.0:compile (compile-protoc) @ hbase-protocol-shaded ---
[INFO] Compiling 31 proto file(s) to /Users/stack/checkouts/hbase.git/hbase-protocol-shaded/target/generated-sources/protobuf/java
[ERROR] PROTOC FAILED: google/protobuf/any.proto: File not found.
Procedure.proto: Import "google/protobuf/any.proto" was not found or had errors.
Procedure.proto:61:12: "google.protobuf.Any" is not defined.
LockService.proto: Import "Procedure.proto" was not found or had errors.
LockService.proto:86:12: "Procedure" is not defined.
LockService.proto:88:12: "Procedure" is not defined.

[ERROR] /Users/stack/checkouts/hbase.git/hbase-protocol-shaded/src/main/protobuf/Client.proto [0:0]: google/protobuf/any.proto: File not found.
Procedure.proto: Import "google/protobuf/any.proto" was not found or had errors.
Procedure.proto:61:12: "google.protobuf.Any" is not defined.
LockService.proto: Import "Procedure.proto" was not found or had errors.
LockService.proto:86:12: "Procedure" is not defined.
LockService.proto:88:12: "Procedure" is not defined.

[ERROR] /Users/stack/checkouts/hbase.git/hbase-protocol-shaded/src/main/protobuf/test_rpc_service.proto [0:0]: google/protobuf/any.proto: File not found.
Procedure.proto: Import "google/protobuf/any.proto" was not found or had errors.
Procedure.proto:61:12: "google.protobuf.Any" is not defined.
LockService.proto: Import "Procedure.proto" was not found or had errors.
LockService.proto:86:12: "Procedure" is not defined.
LockService.proto:88:12: "Procedure" is not defined.
....

Its because of the HBASE-18709 Clean out bundled proto files changes.

Let me revert them. Am afraid relocating will introduce interesting incompat issues.

Issue Links

• relates to: HBASE-22138 Undo our direct dependence on protos in google.protobuf.Any in Procedure.proto