Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22121

AsyncAdmin can not deal with non default meta replica

Details

    • Reviewed

    Description

      In AsyncAdmin we support passing both encodedRegionName and regionName as a parameter so we have a getRegionInfo method to get the RegionInfo first.

      In general we will scan the meta table to get the region info, but for meta region itself, the problem is that, we only check for the first replica, so for the non default replicas, we will still go to the meta region and then get an UnknownRegionException.

      We should find a way to deal with this.

      Attachments

        1. HBASE-22121.patch
          15 kB
          Duo Zhang
        2. HBASE-22121.patch
          15 kB
          Duo Zhang

        Issue Links

          Activity

            zhangduo Duo Zhang added a comment -

            zghaobac FYI.

            zhangduo Duo Zhang added a comment - zghaobac FYI.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 4m 33s Docker mode activated.
                  Prechecks
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                  master Compile Tests
            0 mvndep 0m 28s Maven dependency ordering for branch
            +1 mvninstall 4m 8s master passed
            +1 compile 3m 29s master passed
            +1 checkstyle 1m 38s master passed
            +1 shadedjars 4m 19s branch has no errors when building our shaded downstream artifacts.
            +1 findbugs 3m 21s master passed
            +1 javadoc 0m 52s master passed
                  Patch Compile Tests
            0 mvndep 0m 15s Maven dependency ordering for patch
            +1 mvninstall 3m 56s the patch passed
            +1 compile 3m 30s the patch passed
            -1 javac 2m 39s hbase-server generated 1 new + 193 unchanged - 1 fixed = 194 total (was 194)
            +1 checkstyle 0m 30s hbase-client: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)
            -1 checkstyle 1m 5s hbase-server: The patch generated 2 new + 10 unchanged - 0 fixed = 12 total (was 10)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedjars 4m 16s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 8m 13s Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
            +1 findbugs 3m 30s the patch passed
            +1 javadoc 0m 51s the patch passed
                  Other Tests
            +1 unit 3m 22s hbase-client in the patch passed.
            -1 unit 265m 39s hbase-server in the patch failed.
            +1 asflicense 0m 53s The patch does not generate ASF License warnings.
            319m 38s



            Reason Tests
            Failed junit tests hadoop.hbase.client.TestFromClientSideWithCoprocessor
              hadoop.hbase.TestSplitMerge
              hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
              hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
              hadoop.hbase.master.TestSplitWALManager
              hadoop.hbase.master.TestAssignmentManagerMetrics
              hadoop.hbase.client.TestAsyncTableBatch



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b
            JIRA Issue HBASE-22121
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12964126/HBASE-22121.patch
            Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
            uname Linux 6e6d8be8da34 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / 541f223de4
            maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
            Default Java 1.8.0_181
            findbugs v3.1.11
            javac https://builds.apache.org/job/PreCommit-HBASE-Build/16582/artifact/patchprocess/diff-compile-javac-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/16582/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/16582/artifact/patchprocess/patch-unit-hbase-server.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/16582/testReport/
            Max. process+thread count 5351 (vs. ulimit of 10000)
            modules C: hbase-client hbase-server U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/16582/console
            Powered by Apache Yetus 0.8.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 4m 33s Docker mode activated.       Prechecks +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       master Compile Tests 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 4m 8s master passed +1 compile 3m 29s master passed +1 checkstyle 1m 38s master passed +1 shadedjars 4m 19s branch has no errors when building our shaded downstream artifacts. +1 findbugs 3m 21s master passed +1 javadoc 0m 52s master passed       Patch Compile Tests 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 3m 56s the patch passed +1 compile 3m 30s the patch passed -1 javac 2m 39s hbase-server generated 1 new + 193 unchanged - 1 fixed = 194 total (was 194) +1 checkstyle 0m 30s hbase-client: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14) -1 checkstyle 1m 5s hbase-server: The patch generated 2 new + 10 unchanged - 0 fixed = 12 total (was 10) +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 16s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 8m 13s Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. +1 findbugs 3m 30s the patch passed +1 javadoc 0m 51s the patch passed       Other Tests +1 unit 3m 22s hbase-client in the patch passed. -1 unit 265m 39s hbase-server in the patch failed. +1 asflicense 0m 53s The patch does not generate ASF License warnings. 319m 38s Reason Tests Failed junit tests hadoop.hbase.client.TestFromClientSideWithCoprocessor   hadoop.hbase.TestSplitMerge   hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas   hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory   hadoop.hbase.master.TestSplitWALManager   hadoop.hbase.master.TestAssignmentManagerMetrics   hadoop.hbase.client.TestAsyncTableBatch Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b JIRA Issue HBASE-22121 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12964126/HBASE-22121.patch Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 6e6d8be8da34 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 541f223de4 maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) Default Java 1.8.0_181 findbugs v3.1.11 javac https://builds.apache.org/job/PreCommit-HBASE-Build/16582/artifact/patchprocess/diff-compile-javac-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/16582/artifact/patchprocess/diff-checkstyle-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/16582/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/16582/testReport/ Max. process+thread count 5351 (vs. ulimit of 10000) modules C: hbase-client hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/16582/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
            zhangduo Duo Zhang added a comment -

            The error prone warning is still a bit unstable...Not sure why, maybe we should open an issue on the error prone project as we have already upgraded to the newest version...

            zhangduo Duo Zhang added a comment - The error prone warning is still a bit unstable...Not sure why, maybe we should open an issue on the error prone project as we have already upgraded to the newest version...
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 5m 16s Docker mode activated.
                  Prechecks
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                  master Compile Tests
            0 mvndep 0m 34s Maven dependency ordering for branch
            +1 mvninstall 5m 42s master passed
            +1 compile 4m 52s master passed
            +1 checkstyle 2m 12s master passed
            +1 shadedjars 5m 47s branch has no errors when building our shaded downstream artifacts.
            +1 findbugs 4m 29s master passed
            +1 javadoc 1m 4s master passed
                  Patch Compile Tests
            0 mvndep 0m 16s Maven dependency ordering for patch
            +1 mvninstall 5m 7s the patch passed
            +1 compile 4m 40s the patch passed
            +1 javac 4m 40s the patch passed
            +1 checkstyle 0m 39s hbase-client: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)
            -1 checkstyle 1m 22s hbase-server: The patch generated 2 new + 10 unchanged - 0 fixed = 12 total (was 10)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedjars 5m 32s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 11m 5s Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
            +1 findbugs 4m 42s the patch passed
            +1 javadoc 1m 1s the patch passed
                  Other Tests
            +1 unit 3m 47s hbase-client in the patch passed.
            -1 unit 251m 29s hbase-server in the patch failed.
            +1 asflicense 0m 42s The patch does not generate ASF License warnings.
            321m 11s



            Reason Tests
            Failed junit tests hadoop.hbase.client.TestAdmin1
              hadoop.hbase.client.TestFromClientSideWithCoprocessor
              hadoop.hbase.client.TestFromClientSide



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b
            JIRA Issue HBASE-22121
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12964184/HBASE-22121.patch
            Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
            uname Linux 2cca9c2fe0ab 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / 541f223de4
            maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
            Default Java 1.8.0_181
            findbugs v3.1.11
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/16586/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/16586/artifact/patchprocess/patch-unit-hbase-server.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/16586/testReport/
            Max. process+thread count 5245 (vs. ulimit of 10000)
            modules C: hbase-client hbase-server U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/16586/console
            Powered by Apache Yetus 0.8.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 5m 16s Docker mode activated.       Prechecks +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       master Compile Tests 0 mvndep 0m 34s Maven dependency ordering for branch +1 mvninstall 5m 42s master passed +1 compile 4m 52s master passed +1 checkstyle 2m 12s master passed +1 shadedjars 5m 47s branch has no errors when building our shaded downstream artifacts. +1 findbugs 4m 29s master passed +1 javadoc 1m 4s master passed       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 5m 7s the patch passed +1 compile 4m 40s the patch passed +1 javac 4m 40s the patch passed +1 checkstyle 0m 39s hbase-client: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14) -1 checkstyle 1m 22s hbase-server: The patch generated 2 new + 10 unchanged - 0 fixed = 12 total (was 10) +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 5m 32s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 11m 5s Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. +1 findbugs 4m 42s the patch passed +1 javadoc 1m 1s the patch passed       Other Tests +1 unit 3m 47s hbase-client in the patch passed. -1 unit 251m 29s hbase-server in the patch failed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 321m 11s Reason Tests Failed junit tests hadoop.hbase.client.TestAdmin1   hadoop.hbase.client.TestFromClientSideWithCoprocessor   hadoop.hbase.client.TestFromClientSide Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b JIRA Issue HBASE-22121 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12964184/HBASE-22121.patch Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 2cca9c2fe0ab 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 541f223de4 maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) Default Java 1.8.0_181 findbugs v3.1.11 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/16586/artifact/patchprocess/diff-checkstyle-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/16586/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/16586/testReport/ Max. process+thread count 5245 (vs. ulimit of 10000) modules C: hbase-client hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/16586/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
            zghao Guanghao Zhang added a comment -

            Why don't move the new logic into AsyncMetaTableAccessor?

            zghao Guanghao Zhang added a comment - Why don't move the new logic into AsyncMetaTableAccessor?
            zhangduo Duo Zhang added a comment -

            Because it is for locating meta region itself, not accessing meta?

            zhangduo Duo Zhang added a comment - Because it is for locating meta region itself, not accessing meta?
            zghao Guanghao Zhang added a comment -

            +1

            zghao Guanghao Zhang added a comment - +1
            zhangduo Duo Zhang added a comment -

            Let me commit after fixing the checkstyle issues.

            zhangduo Duo Zhang added a comment - Let me commit after fixing the checkstyle issues.
            zhangduo Duo Zhang added a comment -

            Pushed to branch-2.2+.

            Thanks zghaobac for reviewing.

            zhangduo Duo Zhang added a comment - Pushed to branch-2.2+. Thanks zghaobac for reviewing.
            hudson Hudson added a comment -

            Results for branch branch-2
            build #1787 on builds.a.o: -1 overall


            details (if available):

            +1 general checks
            – For more information see general report

            -1 jdk8 hadoop2 checks
            – For more information see jdk8 (hadoop2) report

            +1 jdk8 hadoop3 checks
            – For more information see jdk8 (hadoop3) report

            +1 source release artifact
            – See build output for details.

            +1 client integration test

            hudson Hudson added a comment - Results for branch branch-2 build #1787 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test
            hudson Hudson added a comment -

            Results for branch branch-2.2
            build #144 on builds.a.o: -1 overall


            details (if available):

            +1 general checks
            – For more information see general report

            -1 jdk8 hadoop2 checks
            – For more information see jdk8 (hadoop2) report

            -1 jdk8 hadoop3 checks
            – For more information see jdk8 (hadoop3) report

            +1 source release artifact
            – See build output for details.

            +1 client integration test

            hudson Hudson added a comment - Results for branch branch-2.2 build #144 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test
            hudson Hudson added a comment -

            Results for branch master
            build #898 on builds.a.o: -1 overall


            details (if available):

            +1 general checks
            – For more information see general report

            -1 jdk8 hadoop2 checks
            – For more information see jdk8 (hadoop2) report

            -1 jdk8 hadoop3 checks
            – For more information see jdk8 (hadoop3) report

            +1 source release artifact
            – See build output for details.

            +1 client integration test

            hudson Hudson added a comment - Results for branch master build #898 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: