[HBASE-22070] Checking restoreDir in RestoreSnapshotHelper

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 2.1.5
• Component/s: snapshots
• Flags: Patch
• Assignee: Vincent Choi
• Reporter: Vincent Choi
• Created: 20/Mar/19 02:45
• Updated: 07/Oct/19 18:39
• Resolved: 06/Apr/19 14:20

Description

The restoreDir shouldn't be a sub directory of rootDir. The code check it with a prefix check "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it goes error in some reasonable cases.

eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I think it's more reasonable to chang the code to "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".