Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21782

LoadIncrementalHFiles should not be IA.Public

    XMLWordPrintableJSON

    Details

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Introduce a BulkLoadHFiles interface which is marked as IA.Public, for doing bulk load programmatically.
      Introduce a BulkLoadHFilesTool which extends BulkLoadHFiles, and is marked as IA.LimitedPrivate(TOOLS), for using from command line.
      The old LoadIncrementalHFiles is deprecated and will be removed in 3.0.0.
      Show
      Introduce a BulkLoadHFiles interface which is marked as IA.Public, for doing bulk load programmatically. Introduce a BulkLoadHFilesTool which extends BulkLoadHFiles, and is marked as IA.LimitedPrivate(TOOLS), for using from command line. The old LoadIncrementalHFiles is deprecated and will be removed in 3.0.0.

      Description

      It is an implementation class, so some of the methods which are only supposed to be used by replication sink are also public to users. And it exposes methods which take Table and Connection as parameter and inside the implementation we assume that they are HTable and ConnectionImplementation, which will be a pain when we want to replace the sync client implementation with async client.

      Here I think we should make the implementation class as IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles programmatically.

        Attachments

        1. HBASE-21782.patch
          17 kB
          Duo Zhang
        2. HBASE-21782-v1.patch
          20 kB
          Duo Zhang

          Issue Links

            Activity

              People

              • Assignee:
                zhangduo Duo Zhang
                Reporter:
                zhangduo Duo Zhang
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: