[HBASE-21683] Reset readsEnabled flag after successfully flushing the primary region

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.3, 2.0.5
• Component/s: read replicas
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 07/Jan/19 10:00
• Updated: 08/Jan/19 23:26
• Resolved: 08/Jan/19 08:24

Description

Found the problem when implementing HBASE-21671, TestRegionReplicaFailover is easy to fail. In this test we set REGION_REPLICA_WAIT_FOR_PRIMARY_FLUSH_CONF_KEY to true, which means the secondary replicas can not be read until the primary region has been successfully flushed. But in RegionReplicaFlushHandler, there is only one place where we call region.setReadsEnabled(true), this is incorrect.