Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21649 Complete Thrift2
  3. HBASE-21652

Refactor ThriftServer making thrift2 server inherited from thrift1 server

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.2.0
    • None
    • None
    • Hide
      Before this issue, thrift1 server and thrift2 server are totally different servers. If a new feature is added to thrift1 server, thrfit2 server have to make the same change to support it(e.g. authorization). After this issue, thrift2 server is inherited from thrift1, thrift2 server now have all the features thrift1 server has(e.g http support, which thrift2 server doesn't have before). The way to start thrift1 or thrift2 server remain the same after this issue.
      Show
      Before this issue, thrift1 server and thrift2 server are totally different servers. If a new feature is added to thrift1 server, thrfit2 server have to make the same change to support it(e.g. authorization). After this issue, thrift2 server is inherited from thrift1, thrift2 server now have all the features thrift1 server has(e.g http support, which thrift2 server doesn't have before). The way to start thrift1 or thrift2 server remain the same after this issue.

    Description

      Except the different protocol, thrift2 Server should have no much difference from thrift1 Server. So refactoring the thrift server, making thrift2 server inherit from thrift1 server. Getting rid of many duplicated code.

      Attachments

        1. HBASE-21652.patch
          237 kB
          Allan Yang
        2. HBASE-21652.v2.patch
          238 kB
          Allan Yang
        3. HBASE-21652.v3.patch
          238 kB
          Allan Yang
        4. HBASE-21652.v4.patch
          249 kB
          Allan Yang
        5. HBASE-21652.v5.patch
          249 kB
          Allan Yang
        6. HBASE-21652.v6.patch
          250 kB
          Allan Yang
        7. HBASE-21652.v7.patch
          250 kB
          Allan Yang
        8. HBASE-21652.branch-2.patch
          249 kB
          Allan Yang
        9. HBASE-21652.addendum.patch
          9 kB
          Allan Yang

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. HBASE-25930 Thrift does not support requests in Kerberos environment

          • Major - Major loss of function.
          • Resolved
          relates to

          Sub-task - The sub-task of the issue HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Review Board

          Activity

            People

              allan163 Allan Yang
              allan163 Allan Yang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: