[HBASE-21635] Use maven enforcer to ban imports from illegal packages

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.2, 2.0.4
• Component/s: build
• Hadoop Flags: Reviewed

Release Note

Use de.skuzzle.enforcer.restrict-imports-enforcer-rule extension for maven enforcer plugin to ban illegal imports at compile time. Now if you use illegal imports, for example, import com.google.common.*, there will be a compile error, instead of a checkstyle warning.

• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 23/Dec/18 10:23
• Updated: 26/Dec/18 16:58
• Resolved: 24/Dec/18 03:49

Description

Now we use checkstyle to report the illegal imports, but it will be easy to be ignored by developpers.

https://github.com/skuzzle/restrict-imports-enforcer-rule

This is an extension for the maven enforcer plugin, which is used to ban imports, and the advantage is that it will cause a compile error, which is not likely to be ignored. The extension is not perfect, but I think it is worth a try.