Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21553

schedLock not released in MasterProcedureScheduler

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • 1.3.3, 1.4.10
    • proc-v2
    • None
    • Reviewed

    Description

      https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java#L749

      As shown above, we didn't unlock schedLock which can cause deadlock.

      Besides this, there are other places in this class handles schedLock.unlock in a risky manner. I'd like to move them to finally block to improve the robustness of handling locks.

      Attachments

        1. HBASE-21553-branch-1.001.patch
          6 kB
          Xu Cang
        2. HBASE-21553-branch-1.002.patch
          6 kB
          Xu Cang

        Issue Links

          is broken by

          Sub-task - The sub-task of the issue HBASE-15105 Procedure V2 - Procedure Queue with Namespaces

          • Major - Major loss of function.
          • Closed

          Activity

            People

              xucang Xu Cang
              xucang Xu Cang
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: