Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21553

schedLock not released in MasterProcedureScheduler

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.3, 1.4.10
    • Component/s: proc-v2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java#L749

      As shown above, we didn't unlock schedLock which can cause deadlock.

      Besides this, there are other places in this class handles schedLock.unlock in a risky manner. I'd like to move them to finally block to improve the robustness of handling locks.

        Attachments

        1. HBASE-21553-branch-1.001.patch
          6 kB
          Xu Cang
        2. HBASE-21553-branch-1.002.patch
          6 kB
          Xu Cang

          Issue Links

            Activity

              People

              • Assignee:
                xucang Xu Cang
                Reporter:
                xucang Xu Cang
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: