Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-212

[hbase] hql.jsp : The character 0x19 is not valid

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      I thought xmlenc would deal with invalid xml characters but seems like it doesn't:

      2007-11-01 16:22:19,773 WARN /: /hql.jsp?q=select+%27anchor%3Aanchor_text%27+from+enwiki+limit%3D17%3B: 
      org.znerd.xmlenc.InvalidXMLException: The character 0x19 is not valid.
              at org.znerd.xmlenc.XMLEncoder.text(Unknown Source)
              at org.znerd.xmlenc.XMLEncoder.text(Unknown Source)
              at org.znerd.xmlenc.XMLOutputter.pcdata(Unknown Source)
              at org.apache.hadoop.hbase.shell.formatter.HtmlTableFormatter.row(HtmlTableFormatter.java:80)
              at org.apache.hadoop.hbase.shell.SelectCommand.scanPrint(SelectCommand.java:216)
              at org.apache.hadoop.hbase.shell.SelectCommand.execute(SelectCommand.java:91)
              at org.apache.hadoop.hbase.generated.master.hql_jsp._jspService(hql_jsp.java:72)
              at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
              at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
              at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:427)
              at org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(WebApplicationHandler.java:475)
              at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:567)
              at org.mortbay.http.HttpContext.handle(HttpContext.java:1565)
              at org.mortbay.jetty.servlet.WebApplicationContext.handle(WebApplicationContext.java:635)
              at org.mortbay.http.HttpContext.handle(HttpContext.java:1517)
              at org.mortbay.http.HttpServer.service(HttpServer.java:954)
              at org.mortbay.http.HttpConnection.service(HttpConnection.java:814)
              at org.mortbay.http.HttpConnection.handleNext(HttpConnection.java:981)
              at org.mortbay.http.HttpConnection.handle(HttpConnection.java:831)
              at org.mortbay.http.SocketListener.handleConnection(SocketListener.java:244)
              at org.mortbay.util.ThreadedServer.handle(ThreadedServer.java:357)
              at org.mortbay.util.ThreadPool$PoolThread.run(ThreadPool.java:534)
      

      Offending cell is:

      +--------------------------------------+--------------------------------------+
      | --jNlYdCLIa-Owwhpomi4F==             |  1 1 tyrone biggums
       1 1 dave chappel|
      |                                      | le show
       1 1 chappelles show        |
      +--------------------------------------+--------------------------------------+
      

        Activity

        Hide
        hudson Hudson added a comment -
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Nightly #290 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/290/ )
        Hide
        stack stack added a comment -

        Committed. Resolving.

        Show
        stack stack added a comment - Committed. Resolving.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12368850/hql.patch
        against trunk revision r591162.

        @author +1. The patch does not contain any @author tags.

        javadoc +1. The javadoc tool did not generate any warning messages.

        javac +1. The applied patch does not generate any new compiler warnings.

        findbugs +1. The patch does not introduce any new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        contrib tests +1. The patch passed contrib unit tests.

        Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/testReport/
        Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12368850/hql.patch against trunk revision r591162. @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1053/console This message is automatically generated.
        Hide
        stack stack added a comment -

        Passes tests locally. Trying my man H.

        Show
        stack stack added a comment - Passes tests locally. Trying my man H.
        Hide
        stack stack added a comment -

        Xmlenc escapes the 5 special chars <, &, etc. but lets all other characters pass.

        Subclass the xmlenc XMLEncoder and replace illegal xml characters with the arbitrary '@'...

        Show
        stack stack added a comment - Xmlenc escapes the 5 special chars <, &, etc. but lets all other characters pass. Subclass the xmlenc XMLEncoder and replace illegal xml characters with the arbitrary '@'...

          People

          • Assignee:
            Unassigned
            Reporter:
            stack stack
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development