Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20828 Finish-up AMv2 Design/List of Tenets/Specification of operation
  3. HBASE-21250

Refactor WALProcedureStore and add more comments for better understanding the implementation

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.1, 2.0.3
    • Component/s: proc-v2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The implementation is complicated and lack of comments to say how it works.

      /**
       * WAL implementation of the ProcedureStore.
       * @see ProcedureWALPrettyPrinter for printing content of a single WAL.
       * @see #main(String[]) to parse a directory of MasterWALProcs.
       */
      

      I think at least we can move sub classes to separated files to make the class smaller, and add more comments to describe what is going on here.

        Attachments

        1. HBASE-21250.patch
          60 kB
          Duo Zhang
        2. HBASE-21250-v1.patch
          83 kB
          Duo Zhang
        3. HBASE-21250-v2.patch
          125 kB
          Duo Zhang
        4. HBASE-21250-v3.patch
          125 kB
          Duo Zhang

          Activity

            People

            • Assignee:
              zhangduo Duo Zhang
              Reporter:
              zhangduo Duo Zhang

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment