Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21243

Correct java-doc for the method RpcServer.getRemoteAddress()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Patch Available
    • Trivial
    • Resolution: Unresolved
    • 3.0.0-alpha-1, 2.0.0
    • 3.0.0-alpha-4
    • None

    Description

      Correct the java-doc for the method RpcServer.getRemoteAddress().
      Currently it look like as below:

        /**
         * @return Address of remote client if a request is ongoing, else null
         */
        public static Optional<InetAddress> getRemoteAddress() {
          return getCurrentCall().map(RpcCall::getRemoteAddress);
        }
      

      Contrary to the doc the method will never return null. Rather it may return an empty Optional.

      Attachments

        1. HBASE-21243.master.001.patch
          1 kB
          Nihal Jain
        2. HBASE-21243.master.002.patch
          1 kB
          Nihal Jain

        Activity

          People

            nihaljain.cs Nihal Jain
            nihaljain.cs Nihal Jain
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated: