[HBASE-21208] Bytes#toShort doesn't work without unsafe

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.5.0, 2.2.0, 2.1.1, 2.0.3
• Hadoop Flags: Reviewed
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 18/Sep/18 14:10
• Updated: 12/Jan/19 05:08
• Resolved: 25/Sep/18 02:33

Description

seems we put the brackets in the wrong place.

      short n = 0;
      n = (short) ((n ^ bytes[offset]) & 0xFF);
      n = (short) (n << 8);
      n = (short) ((n ^ bytes[offset+1]) & 0xFF);   // this one
      return n;

Issue Links

• is broken by: HBASE-19497 Fix findbugs and error-prone warnings in hbase-common (branch-2)