[HBASE-21153] Shaded client jars should always build in relevant phase to avoid confusion

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.1.0, 2.2.0
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.1
• Component/s: build

Release Note

Client facing artifacts are now built whenever Maven is run through the "package" goal. Previously, the client facing artifacts would create placeholder jars that skipped repackaging HBase and third-party dependencies unless the "release" profile was active.

Build times may be noticeably longer depending on your build hardware. For example, the Jenkins worker nodes maintained by ASF Infra take ~14% longer to do a full packaging build. An example portability-focused personal laptop took ~25% longer.

• Assignee: Sean Busbey
• Reporter: Michael Stack
• Created: 05/Sep/18 03:18
• Updated: 13/Sep/18 16:03
• Resolved: 05/Sep/18 22:02

Description

edit:

Now that our assembly directly relies on the shaded clients, failing to build the actual client jars (e.g. because -P release is required to fill in their contents) causes confusing errors for downstream folks about classes not being found when they run simple commands like hbase version.

We should always fill in the shaded artifacts to make our build easier to understand.

original report:: When I run the hbase version command it comes back with:

$ ./bin/hbase version
Error: Could not find or load main class org.apache.hadoop.hbase.util.GetJavaProperty
Error: Could not find or load main class org.apache.hadoop.hbase.util.VersionInfo

The two classes are in hbase-commons.

The nice shaded refactoring of our bin/hbase – i.e. using shaded jars wherever possible – may have overstretched expecting version to work with shaded client (busbey ?). If so, fix is < one-liner.

Issue Links

• breaks: HBASE-21182 Failed to execute start-hbase.sh
• is related to: HBASE-20615 emphasize use of shaded client jars when they're present in an install