[HBASE-21138] Close HRegion instance at the end of every test in TestHRegion

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 1.3.3, 2.2.0, 1.4.8
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Ted Yu
• Created: 31/Aug/18 22:00
• Updated: 01/Feb/19 20:29
• Resolved: 07/Sep/18 00:52

Description

TestHRegion has over 100 tests.
The following is from one subtest:

  public void testCompactionAffectedByScanners() throws Exception {
    byte[] family = Bytes.toBytes("family");
    this.region = initHRegion(tableName, method, CONF, family);

this.region is not closed at the end of the subtest.

testToShowNPEOnRegionScannerReseek is another example.

Every subtest should use the following construct toward the end:

    } finally {
      HBaseTestingUtility.closeRegionAndWAL(this.region);

Issue Links

• relates to: HBASE-21173 Remove the duplicate HRegion#close in TestHRegion
• links to: Review Board #68631