Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
3.0.0-alpha-1, 2.2.0
-
None
-
Reviewed
Description
It is a follow-up of HBASE-19008, aiming to clean up duplicate codes in #equals and #hashCode methods.
Attachments
Attachments
- HBASE-21129.master.001.patch
- 38 kB
- Reid Chan
- HBASE-21129.master.002.patch
- 38 kB
- Reid Chan
- HBASE-21129.master.003.patch
- 39 kB
- Reid Chan
- HBASE-21129.master.004.patch
- 40 kB
- Reid Chan
- HBASE-21129.master.005.patch
- 40 kB
- Reid Chan
- HBASE-21129.master.006.patch
- 40 kB
- Reid Chan
- HBASE-21129.master.007.patch
- 40 kB
- Reid Chan
- HBASE-21129.master.008.patch
- 40 kB
- Reid Chan
- 21129.addendum
- 0.8 kB
- Ted Yu
Issue Links
- relates to
-
HBASE-22212 [1.x] Backport missing filter improvements
- Resolved
-
HBASE-22214 [2.x] Backport missing filter improvements
- Resolved
Activity
For FamilyFilter.java, hashCode is dropped. This is because we are using CompareFilter's hashCode ?
For FirstKeyOnlyFilter.java and MobReferenceOnlyFilter, you add equals(). Please add hashCode as well.
Thanks for the cleanup.
hashCode is dropped. This is because we are using CompareFilter's hashCode ?
yes
Please add hashCode as well.
those two filters has no member to hash, any suggestion?
For FirstKeyOnlyFilter, can you use foundKV ?
I don't have suggestion for MobReferenceOnlyFilter
You can leave it out.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 14s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 24s | Maven dependency ordering for branch |
+1 | mvninstall | 3m 41s | master passed |
-1 | compile | 1m 18s | hbase-server in master failed. |
+1 | checkstyle | 2m 6s | master passed |
+1 | shadedjars | 4m 22s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 40s | master passed |
+1 | javadoc | 1m 4s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for patch |
-1 | mvninstall | 1m 34s | root in the patch failed. |
-1 | compile | 0m 24s | hbase-client in the patch failed. |
-1 | compile | 0m 21s | hbase-server in the patch failed. |
-1 | javac | 0m 24s | hbase-client in the patch failed. |
-1 | javac | 0m 21s | hbase-server in the patch failed. |
-1 | checkstyle | 0m 39s | hbase-client: The patch generated 5 new + 421 unchanged - 0 fixed = 426 total (was 421) |
-1 | checkstyle | 0m 37s | hbase-server: The patch generated 1 new + 0 unchanged - 36 fixed = 1 total (was 36) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
-1 | shadedjars | 3m 0s | patch has 14 errors when building our shaded downstream artifacts. |
-1 | hadoopcheck | 1m 27s | The patch causes 15 errors with Hadoop v2.7.4. |
-1 | hadoopcheck | 2m 58s | The patch causes 15 errors with Hadoop v3.0.0. |
-1 | findbugs | 1m 5s | hbase-client generated 28 new + 0 unchanged - 0 fixed = 28 total (was 0) |
-1 | findbugs | 0m 20s | hbase-server in the patch failed. |
-1 | javadoc | 0m 14s | hbase-server in the patch failed. |
Other Tests | |||
+1 | unit | 3m 4s | hbase-client in the patch passed. |
-1 | unit | 0m 20s | hbase-server in the patch failed. |
+1 | unit | 4m 38s | hbase-spark in the patch passed. |
+1 | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
42m 22s |
Reason | Tests |
---|---|
FindBugs | module:hbase-client |
Equals method for org.apache.hadoop.hbase.filter.ColumnCountGetFilter assumes the argument is of type ColumnCountGetFilter At ColumnCountGetFilter.java:the argument is of type ColumnCountGetFilter At ColumnCountGetFilter.java:[line 139] | |
Equals method for org.apache.hadoop.hbase.filter.ColumnPaginationFilter assumes the argument is of type ColumnPaginationFilter At ColumnPaginationFilter.java:the argument is of type ColumnPaginationFilter At ColumnPaginationFilter.java:[line 237] | |
Equals method for org.apache.hadoop.hbase.filter.ColumnPrefixFilter assumes the argument is of type ColumnPrefixFilter At ColumnPrefixFilter.java:the argument is of type ColumnPrefixFilter At ColumnPrefixFilter.java:[line 167] | |
Equals method for org.apache.hadoop.hbase.filter.ColumnRangeFilter assumes the argument is of type ColumnRangeFilter At ColumnRangeFilter.java:the argument is of type ColumnRangeFilter At ColumnRangeFilter.java:[line 246] | |
Equals method for org.apache.hadoop.hbase.filter.ColumnValueFilter assumes the argument is of type ColumnValueFilter At ColumnValueFilter.java:the argument is of type ColumnValueFilter At ColumnValueFilter.java:[line 245] | |
Equals method for org.apache.hadoop.hbase.filter.CompareFilter assumes the argument is of type CompareFilter At CompareFilter.java:the argument is of type CompareFilter At CompareFilter.java:[line 328] | |
Equals method for org.apache.hadoop.hbase.filter.DependentColumnFilter assumes the argument is of type DependentColumnFilter At DependentColumnFilter.java:the argument is of type DependentColumnFilter At DependentColumnFilter.java:[line 318] | |
Equals method for org.apache.hadoop.hbase.filter.FamilyFilter assumes the argument is of type FamilyFilter At FamilyFilter.java:the argument is of type FamilyFilter At FamilyFilter.java:[line 152] | |
Equals method for org.apache.hadoop.hbase.filter.FilterList assumes the argument is of type FilterList At FilterList.java:the argument is of type FilterList At FilterList.java:[line 283] | |
Equals method for org.apache.hadoop.hbase.filter.FirstKeyOnlyFilter assumes the argument is of type FirstKeyOnlyFilter At FirstKeyOnlyFilter.java:the argument is of type FirstKeyOnlyFilter At FirstKeyOnlyFilter.java:[line 133] | |
Equals method for org.apache.hadoop.hbase.filter.FirstKeyValueMatchingQualifiersFilter assumes the argument is of type FirstKeyValueMatchingQualifiersFilter At FirstKeyValueMatchingQualifiersFilter.java:the argument is of type FirstKeyValueMatchingQualifiersFilter At FirstKeyValueMatchingQualifiersFilter.java:[line 140] | |
Equals method for org.apache.hadoop.hbase.filter.FuzzyRowFilter assumes the argument is of type FuzzyRowFilter At FuzzyRowFilter.java:the argument is of type FuzzyRowFilter At FuzzyRowFilter.java:[line 653] | |
Equals method for org.apache.hadoop.hbase.filter.InclusiveStopFilter assumes the argument is of type InclusiveStopFilter At InclusiveStopFilter.java:the argument is of type InclusiveStopFilter At InclusiveStopFilter.java:[line 137] | |
Equals method for org.apache.hadoop.hbase.filter.KeyOnlyFilter assumes the argument is of type KeyOnlyFilter At KeyOnlyFilter.java:the argument is of type KeyOnlyFilter At KeyOnlyFilter.java:[line 140] | |
Equals method for org.apache.hadoop.hbase.filter.MultiRowRangeFilter assumes the argument is of type MultiRowRangeFilter At MultiRowRangeFilter.java:the argument is of type MultiRowRangeFilter At MultiRowRangeFilter.java:[line 543] | |
Equals method for org.apache.hadoop.hbase.filter.MultipleColumnPrefixFilter assumes the argument is of type MultipleColumnPrefixFilter At MultipleColumnPrefixFilter.java:the argument is of type MultipleColumnPrefixFilter At MultipleColumnPrefixFilter.java:[line 214] | |
Equals method for org.apache.hadoop.hbase.filter.PageFilter assumes the argument is of type PageFilter At PageFilter.java:the argument is of type PageFilter At PageFilter.java:[line 157] | |
Equals method for org.apache.hadoop.hbase.filter.PrefixFilter assumes the argument is of type PrefixFilter At PrefixFilter.java:the argument is of type PrefixFilter At PrefixFilter.java:[line 162] | |
Equals method for org.apache.hadoop.hbase.filter.QualifierFilter assumes the argument is of type QualifierFilter At QualifierFilter.java:the argument is of type QualifierFilter At QualifierFilter.java:[line 149] | |
Equals method for org.apache.hadoop.hbase.filter.RandomRowFilter assumes the argument is of type RandomRowFilter At RandomRowFilter.java:the argument is of type RandomRowFilter At RandomRowFilter.java:[line 161] | |
Equals method for org.apache.hadoop.hbase.filter.RowFilter assumes the argument is of type RowFilter At RowFilter.java:the argument is of type RowFilter At RowFilter.java:[line 166] | |
org.apache.hadoop.hbase.filter.RowFilter defines equals but not hashCode At RowFilter.java:hashCode At RowFilter.java:[line 166] | |
Equals method for org.apache.hadoop.hbase.filter.SingleColumnValueExcludeFilter assumes the argument is of type SingleColumnValueExcludeFilter At SingleColumnValueExcludeFilter.java:the argument is of type SingleColumnValueExcludeFilter At SingleColumnValueExcludeFilter.java:[line 247] | |
Equals method for org.apache.hadoop.hbase.filter.SingleColumnValueFilter assumes the argument is of type SingleColumnValueFilter At SingleColumnValueFilter.java:the argument is of type SingleColumnValueFilter At SingleColumnValueFilter.java:[line 467] | |
Equals method for org.apache.hadoop.hbase.filter.SkipFilter assumes the argument is of type SkipFilter At SkipFilter.java:the argument is of type SkipFilter At SkipFilter.java:[line 168] | |
Equals method for org.apache.hadoop.hbase.filter.TimestampsFilter assumes the argument is of type TimestampsFilter At TimestampsFilter.java:the argument is of type TimestampsFilter At TimestampsFilter.java:[line 245] | |
Equals method for org.apache.hadoop.hbase.filter.ValueFilter assumes the argument is of type ValueFilter At ValueFilter.java:the argument is of type ValueFilter At ValueFilter.java:[line 145] | |
Equals method for org.apache.hadoop.hbase.filter.WhileMatchFilter assumes the argument is of type WhileMatchFilter At WhileMatchFilter.java:the argument is of type WhileMatchFilter At WhileMatchFilter.java:[line 170] |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 10s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for branch |
+1 | mvninstall | 3m 29s | master passed |
-1 | compile | 1m 17s | hbase-server in master failed. |
+1 | checkstyle | 2m 0s | master passed |
+1 | shadedjars | 4m 18s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 4m 1s | master passed |
+1 | javadoc | 1m 6s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 54s | the patch passed |
-1 | compile | 0m 25s | hbase-client in the patch failed. |
-1 | compile | 1m 27s | hbase-server in the patch failed. |
-1 | javac | 0m 25s | hbase-client in the patch failed. |
-1 | javac | 1m 27s | hbase-server in the patch failed. |
-1 | checkstyle | 1m 13s | hbase-server: The patch generated 1 new + 35 unchanged - 1 fixed = 36 total (was 36) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 13s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 8m 9s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
-1 | findbugs | 2m 11s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
+1 | javadoc | 1m 1s | the patch passed |
Other Tests | |||
+1 | unit | 3m 1s | hbase-client in the patch passed. |
-1 | unit | 118m 11s | hbase-server in the patch failed. |
+1 | unit | 4m 37s | hbase-spark in the patch passed. |
+1 | asflicense | 0m 56s | The patch does not generate ASF License warnings. |
172m 59s |
Reason | Tests |
---|---|
FindBugs | module:hbase-server |
org.apache.hadoop.hbase.regionserver.MobReferenceOnlyFilter defines equals and uses Object.hashCode() At MobReferenceOnlyFilter.java:Object.hashCode() At MobReferenceOnlyFilter.java:[lines 45-48] | |
Failed junit tests | hadoop.hbase.master.procedure.TestCloneSnapshotProcedure |
hadoop.hbase.master.procedure.TestDisableTableProcedure | |
hadoop.hbase.client.TestAsyncClusterAdminApi |
This message was automatically generated.
Test failures were not related.
After addressing FindBugs warning, should be good to go.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 30s | Maven dependency ordering for branch |
+1 | mvninstall | 3m 53s | master passed |
-1 | compile | 1m 17s | hbase-server in master failed. |
+1 | checkstyle | 2m 0s | master passed |
+1 | shadedjars | 4m 11s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 35s | master passed |
+1 | javadoc | 1m 4s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 39s | the patch passed |
-1 | compile | 0m 25s | hbase-client in the patch failed. |
-1 | compile | 1m 17s | hbase-server in the patch failed. |
-1 | javac | 0m 25s | hbase-client in the patch failed. |
-1 | javac | 1m 17s | hbase-server in the patch failed. |
+1 | checkstyle | 0m 39s | The patch hbase-client passed checkstyle |
+1 | checkstyle | 1m 10s | hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36) |
+1 | checkstyle | 0m 11s | The patch hbase-spark passed checkstyle |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 13s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 7m 37s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 4m 17s | the patch passed |
+1 | javadoc | 1m 15s | the patch passed |
Other Tests | |||
+1 | unit | 3m 13s | hbase-client in the patch passed. |
-1 | unit | 123m 34s | hbase-server in the patch failed. |
+1 | unit | 4m 37s | hbase-spark in the patch passed. |
+1 | asflicense | 0m 58s | The patch does not generate ASF License warnings. |
177m 46s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
hadoop.hbase.master.procedure.TestTruncateTableProcedure | |
hadoop.hbase.client.TestCloneSnapshotFromClient |
This message was automatically generated.
v5 fixed this warning: ColumnPaginationFilter.java:[243,19] [ArrayHashCode] hashcode method on array does not hash array contents
Others -1 are about UnitTests, looks like they become flaky when QA is backs.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 42s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 25s | master passed |
-1 | compile | 1m 18s | hbase-server in master failed. |
+1 | checkstyle | 2m 2s | master passed |
+1 | shadedjars | 4m 12s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 34s | master passed |
+1 | javadoc | 1m 5s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 15s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 36s | the patch passed |
-1 | compile | 0m 26s | hbase-client in the patch failed. |
-1 | compile | 1m 16s | hbase-server in the patch failed. |
-1 | javac | 0m 26s | hbase-client in the patch failed. |
-1 | javac | 1m 16s | hbase-server in the patch failed. |
+1 | checkstyle | 0m 38s | The patch hbase-client passed checkstyle |
+1 | checkstyle | 1m 11s | hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36) |
+1 | checkstyle | 0m 11s | The patch hbase-spark passed checkstyle |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 11s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 7m 35s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 3m 54s | the patch passed |
+1 | javadoc | 1m 5s | the patch passed |
Other Tests | |||
+1 | unit | 2m 58s | hbase-client in the patch passed. |
-1 | unit | 121m 8s | hbase-server in the patch failed. |
+1 | unit | 4m 56s | hbase-spark in the patch passed. |
+1 | asflicense | 1m 4s | The patch does not generate ASF License warnings. |
175m 41s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.master.procedure.TestTruncateTableProcedure |
hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | |
hadoop.hbase.client.TestCloneSnapshotFromClient |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 14s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for branch |
+1 | mvninstall | 3m 51s | master passed |
-1 | compile | 1m 22s | hbase-server in master failed. |
+1 | checkstyle | 2m 7s | master passed |
+1 | shadedjars | 4m 17s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 47s | master passed |
+1 | javadoc | 1m 6s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 46s | the patch passed |
-1 | compile | 0m 25s | hbase-client in the patch failed. |
-1 | compile | 1m 22s | hbase-server in the patch failed. |
-1 | javac | 0m 25s | hbase-client in the patch failed. |
-1 | javac | 1m 22s | hbase-server in the patch failed. |
+1 | checkstyle | 0m 38s | The patch hbase-client passed checkstyle |
+1 | checkstyle | 1m 13s | hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36) |
+1 | checkstyle | 0m 11s | The patch hbase-spark passed checkstyle |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 8m 40s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 5m 22s | the patch passed |
+1 | javadoc | 1m 22s | the patch passed |
Other Tests | |||
+1 | unit | 3m 36s | hbase-client in the patch passed. |
-1 | unit | 138m 36s | hbase-server in the patch failed. |
+1 | unit | 4m 52s | hbase-spark in the patch passed. |
+1 | asflicense | 0m 58s | The patch does not generate ASF License warnings. |
196m 45s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.master.procedure.TestTruncateTableProcedure |
hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | |
hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | |
hadoop.hbase.client.TestCloneSnapshotFromClient | |
hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 9s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 36s | Maven dependency ordering for branch |
+1 | mvninstall | 3m 50s | master passed |
+1 | compile | 3m 27s | master passed |
+1 | checkstyle | 2m 2s | master passed |
+1 | shadedjars | 4m 22s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 4m 10s | master passed |
+1 | javadoc | 1m 16s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 15s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 54s | the patch passed |
-1 | compile | 0m 30s | hbase-client in the patch failed. |
-1 | javac | 0m 30s | hbase-client in the patch failed. |
+1 | checkstyle | 0m 39s | The patch hbase-client passed checkstyle |
+1 | checkstyle | 1m 11s | hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36) |
+1 | checkstyle | 0m 11s | The patch hbase-spark passed checkstyle |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 14s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 7m 58s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 4m 5s | the patch passed |
+1 | javadoc | 1m 6s | the patch passed |
Other Tests | |||
+1 | unit | 3m 5s | hbase-client in the patch passed. |
+1 | unit | 113m 43s | hbase-server in the patch passed. |
+1 | unit | 4m 39s | hbase-spark in the patch passed. |
+1 | asflicense | 0m 59s | The patch does not generate ASF License warnings. |
170m 21s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12938076/HBASE-21129.master.007.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux ff7f6c5ca3f0 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / dc79029966 |
maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
Default Java | 1.8.0_181 |
findbugs | v3.1.0-RC3 |
compile | https://builds.apache.org/job/PreCommit-HBASE-Build/14284/artifact/patchprocess/patch-compile-hbase-client.txt |
javac | https://builds.apache.org/job/PreCommit-HBASE-Build/14284/artifact/patchprocess/patch-compile-hbase-client.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14284/testReport/ |
Max. process+thread count | 4659 (vs. ulimit of 10000) |
modules | C: hbase-client hbase-server hbase-spark U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14284/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 14s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for branch |
+1 | mvninstall | 3m 45s | master passed |
+1 | compile | 3m 36s | master passed |
+1 | checkstyle | 2m 1s | master passed |
+1 | shadedjars | 4m 21s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 46s | master passed |
+1 | javadoc | 1m 7s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 45s | the patch passed |
+1 | compile | 3m 37s | the patch passed |
+1 | javac | 3m 37s | the patch passed |
+1 | checkstyle | 0m 39s | The patch hbase-client passed checkstyle |
+1 | checkstyle | 1m 15s | hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36) |
+1 | checkstyle | 0m 14s | The patch hbase-spark passed checkstyle |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 47s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 9m 24s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 4m 48s | the patch passed |
+1 | javadoc | 1m 28s | the patch passed |
Other Tests | |||
+1 | unit | 3m 15s | hbase-client in the patch passed. |
-1 | unit | 129m 25s | hbase-server in the patch failed. |
+1 | unit | 9m 15s | hbase-spark in the patch passed. |
+1 | asflicense | 3m 36s | The patch does not generate ASF License warnings. |
195m 51s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.client.TestBlockEvictionFromClient |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12938100/HBASE-21129.master.008.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 0a7e1fb65a03 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / dc79029966 |
maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
Default Java | 1.8.0_181 |
findbugs | v3.1.0-RC3 |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14289/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14289/testReport/ |
Max. process+thread count | 5031 (vs. ulimit of 10000) |
modules | C: hbase-client hbase-server hbase-spark U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14289/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
Results for branch master
build #472 on builds.a.o: -1 overall
details (if available):
-1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– Something went wrong running this stage, please check relevant console output.
-1 jdk8 hadoop3 checks
– Something went wrong running this stage, please check relevant console output.
+1 source release artifact
– See build output for details.
+1 client integration test
Results for branch branch-2
build #1198 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
+1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
+1 client integration test
reopening because this patch caused a failure in nightly's scaladoc check.
Here's the report for master branch that nightly tried to link to:
https://builds.apache.org/job/HBase%20Nightly/job/master/472/General_20Nightly_20Build_20Report/
and here's the specific error log for scaladoc:
please push an addendum to relevant branches or revert.
Results for branch master
build #478 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
+1 client integration test
Results for branch branch-2.1
build #1046 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
+1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
+1 client integration test
Results for branch branch-2.0
build #1512 on builds.a.o: +1 overall
details (if available):
+1 general checks
– For more information see general report
+1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
+1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
cc tedyu