Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21070

SnapshotFileCache won't update for snapshots stored in S3

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.1.1, 1.4.7
    • Fix Version/s: 3.0.0, 1.5.0, 2.3.0
    • Component/s: snapshots
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The SnapshotFileCache depends on last modified time to determine whether to update the Snapshot HFile cache. However, in S3, real 'folders' don't exist. S3 filesystems create a dummy file in place of a folder, but the dummy file last modified time is not updated when files are changed 'under' it. This means that the SnapshotFileCache doesn't pick up new snapshot HFiles and these files aren't removed from the HFileCleaner and can be eligible for deletion.

       

      My patch removes the lastmodified assumption.

        Attachments

        1. HBASE-21070.master.001.patch
          7 kB
          Zach York
        2. HBASE-21070.master.002.patch
          7 kB
          Zach York
        3. HBASE-21070.master.003.patch
          14 kB
          Zach York

          Issue Links

            Activity

              People

              • Assignee:
                zyork Zach York
                Reporter:
                zyork Zach York
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: