Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21047

Object creation of StoreFileScanner thru constructor and close may leave refCount to -1

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0, 1.3.3, 2.2.0, 2.1.1, 2.0.2, 1.4.7
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      During object creation  "StoreFileScanner", it does not increase the refCount whereas while close it decrements the reader refCount. This will cause refCount to -1 and isReadReference method was returning true (refCount.get() != 0 This is causing store file not to be deleted. This may also cause issue in situation when some thread is holding a scanner but it may actually be closed due to above bug. Impact of this would be really high. Attatching patch for the fix which makes sure if reference is held either thru getScanner method or constructor, ref is always updated. Patch also contains a test which validates the issue. 

        Attachments

        1. HBASE-21047.branch-1.v1.patch
          4 kB
          Vishal Khandelwal
        2. HBASE-21047.branch-1.v2.patch
          4 kB
          Vishal Khandelwal
        3. HBASE-21047.v1.patch
          6 kB
          Vishal Khandelwal

          Issue Links

            Activity

              People

              • Assignee:
                vishk Vishal Khandelwal
                Reporter:
                vishk Vishal Khandelwal
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: