[HBASE-21047] Object creation of StoreFileScanner thru constructor and close may leave refCount to -1

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 1.3.3, 2.2.0, 2.1.1, 2.0.2, 1.4.7
• Hadoop Flags: Reviewed
• Assignee: Vishal Khandelwal
• Reporter: Vishal Khandelwal
• Created: 14/Aug/18 05:57
• Updated: 01/Feb/19 20:11
• Resolved: 16/Aug/18 22:21

Description

During object creation  "StoreFileScanner", it does not increase the refCount whereas while close it decrements the reader refCount. This will cause refCount to -1 and isReadReference method was returning true (refCount.get() != 0 This is causing store file not to be deleted. This may also cause issue in situation when some thread is holding a scanner but it may actually be closed due to above bug. Impact of this would be really high. Attatching patch for the fix which makes sure if reference is held either thru getScanner method or constructor, ref is always updated. Patch also contains a test which validates the issue. 

Issue Links

• is a child of: HBASE-21063 IndexHalfStoreFileReaderGenerator.getLocalIndexScanners creates an scanner which would store file reference count to -1
• is a parent of: PHOENIX-4852 IndexHalfStoreFileReaderGenerator.getLocalIndexScanners creates an scanner which would store file reference count to -1