[HBASE-20764] build broken when latest commit is gpg signed

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 3.0.0-alpha-1, 1.5.0, 2.2.0, 2.1.1, 2.0.3
• Component/s: build
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 20/Jun/18 22:20
• Updated: 09/Oct/18 13:25
• Resolved: 09/Oct/18 00:54

Description

This issue happens if somebody has log.showsignature=true in their local gitconfig.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project hbase-common: Compilation failure: Compilation failure:
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] unclosed string literal
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] <identifier> expected
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] ';' expected
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] malformed floating point literal
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] ';' expected
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] ';' expected
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] <identifier> expected
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] illegal start of type
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] ';' expected
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] unclosed string literal

Which complains because:

  public static final String revision = "gpg: Signature made Wed Jun 20 09:42:38 2018 PDT
gpg:                using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E
gpg: Good signature from "Mike Drob (CODE SIGNING KEY) <[e-mail]>" [ultimate]
d1cad1a25432ffcd75cd654e9bf68233ca7e1957";

And this comes from src/saveVersion.sh where it does:

  revision=`git log -1 --pretty=format:"%H"`

Issue Links

• links to: Review Board (master)