[HBASE-20710] extra cloneFamily() in Mutation.add(Cell)

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.1
• Fix Version/s: 3.0.0, 2.1.0, 2.0.2
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Hua Xiang
• Reporter: Hua Xiang
• Created: 09/Jun/18 14:12
• Updated: 04/Mar/19 09:40
• Resolved: 24/Jun/18 03:39

Description

The cpu profiling shows that during PE randomWrite testing, about 1 percent of time is spent in cloneFamily. Reviewing code found that when a cell is DBB backed ByteBuffKeyValueCell (which is default with Netty Rpc), cell.getFamilyArray() will call cloneFamily() and there is again a cloneFamily() in the following line of the code. since this is the critical write path processing, this needs to be optimized.

https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java#L791

https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java#L795

Issue Links

• Is contained by: HBASE-20188 [TESTING] Performance
• links to: Review Board (master)