[HBASE-20704] Sometimes some compacted storefiles are not archived on region close

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 1.3.0, 1.4.0, 1.5.0, 2.0.0
• Fix Version/s: 3.0.0-alpha-1, 1.3.3, 2.2.0, 1.4.8, 2.1.1, 2.0.3
• Component/s: Compaction
• Hadoop Flags: Reviewed
• Assignee: Francis Christopher Liu
• Reporter: Francis Christopher Liu
• Created: 07/Jun/18 17:23
• Updated: 23/Jun/22 18:45
• Resolved: 21/Sep/18 23:18

Description

During region close compacted files which have not yet been archived by the discharger are archived as part of the region closing process. It is important that these files are wholly archived to insure data consistency. ie a storefile containing delete tombstones can be archived while older storefiles containing cells that were supposed to be deleted are left unarchived thereby undeleting those cells. 

On region close a compacted storefile is skipped from archiving if it has read references (ie open scanners). This behavior is correct for when the discharger chore runs but on region close consistency is of course more important so we should add a special case to ignore any references on the storefile and go ahead and archive it. 

Attached patch contains a unit test that reproduces the problem and the proposed fix.

Issue Links

• causes: HBASE-21551 Memory leak when use scan with STREAM at server side
• is related to: HBASE-20724 Sometimes some compacted storefiles are still opened after region failover
• relates to: HBASE-13082 Coarsen StoreScanner locks to RegionScanner
• links to: reviewboard for master