[HBASE-20657] Retrying RPC call for ModifyTableProcedure may get stuck

• Type: Bug
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Component/s: Client, proc-v2
• Assignee: Unassigned
• Reporter: Sergey Soldatov
• Created: 29/May/18 23:27
• Updated: 23/Jun/22 19:27

Description

Env: 2 masters, 1 RS.
Steps to reproduce: Active master is killed while ModifyTableProcedure is executed.
If the table has enough regions it may come that when the secondary master get active some of the regions may be closed, so once client retries the call to the new active master, a new ModifyTableProcedure is created and get stuck during MODIFY_TABLE_REOPEN_ALL_REGIONS state handling. That happens because:
1. When we are retrying from client side, we call modifyTableAsync which create a procedure with a new nonce key:

         ModifyTableRequest request = RequestConverter.buildModifyTableRequest(
            td.getTableName(), td, ng.getNonceGroup(), ng.newNonce());

So on the server side, it's considered as a new procedure and starts executing immediately.
2. When we are processing MODIFY_TABLE_REOPEN_ALL_REGIONS we create MoveRegionProcedure for each region, but it checks whether the region is online (and it's not), so it fails immediately, forcing the procedure to restart.

[e-mail] saw a similar case when two concurrent ModifyTable procedures were running and got stuck in the similar way.

Issue Links

• is related to: HBASE-20569 NPE in RecoverStandbyProcedure.execute
• relates to: HBASE-20752 Make sure the regions are truly reopened after ReopenTableRegionsProcedure