Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20639

Implement permission checking through AccessController instead of RSGroupAdminEndpoint

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • None
    • None
    • None
    • None
    • Reviewed

    Description

      Currently permission checking for various RS group operations is done via RSGroupAdminEndpoint.
      e.g. in RSGroupAdminServiceImpl#moveServers() :

              checkPermission("moveServers");
              groupAdminServer.moveServers(hostPorts, request.getTargetGroup());
      

      The practice in remaining parts of hbase is to perform permission checking within AccessController.

      Now that observer hooks for RS group operations are in right place, we should follow best practice and move permission checking to AccessController.

      Attachments

        1. HBASE-20639.master.001.patch
          15 kB
          Nihal Jain
        2. HBASE-20639.master.002.patch
          15 kB
          Nihal Jain
        3. HBASE-20639.master.002.patch
          15 kB
          Nihal Jain

        Issue Links

          Activity

            People

              nihaljain.cs Nihal Jain
              yuzhihong@gmail.com Ted Yu
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: