Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20627

Relocate RS Group pre/post hooks from RSGroupAdminServer to RSGroupAdminEndpoint

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.1.0, 1.4.5
    • None
    • None
    • Reviewed

    Description

      Currently RS Group pre/post hooks are called from RSGroupAdminServer.
      e.g. RSGroupAdminServer#removeRSGroup :

            if (master.getMasterCoprocessorHost() != null) {
              master.getMasterCoprocessorHost().preRemoveRSGroup(name);
            }
      

      RSGroupAdminServer#removeRSGroup is called by RSGroupAdminEndpoint :

              checkPermission("removeRSGroup");
              groupAdminServer.removeRSGroup(request.getRSGroupName());
      

      If permission check fails, the pre hook wouldn't be called.

      Attachments

        1. 20627.branch-1.txt
          20 kB
          Ted Yu
        2. 20627.v3.txt
          21 kB
          Ted Yu
        3. 20627.v2.txt
          16 kB
          Ted Yu
        4. 20627.v1.txt
          12 kB
          Ted Yu

        Activity

          People

            yuzhihong@gmail.com Ted Yu
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: