Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-2059

Break out WAL reader and writer impl from HLog

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.90.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Use Configuration and reflection to bind HLog reader and writer at runtime, to allow users to chose between different HLog reader/writer implementation pairs.

      1. HBASE-2059.patch
        41 kB
        Andrew Purtell

        Issue Links

          Activity

          Hide
          jdcryans Jean-Daniel Cryans added a comment -

          +1 looks great. Do you plan to add hbase.regionserver.hlog.writer.impl in hbase-default?

          Show
          jdcryans Jean-Daniel Cryans added a comment - +1 looks great. Do you plan to add hbase.regionserver.hlog.writer.impl in hbase-default?
          Hide
          apurtell Andrew Purtell added a comment -

          Passes all local tests, importantly:

          • TestFullLogReconstruction
          • TestHLog

          I'd like to see this go in. It's the foundation for a bake off between different log formats, for example, SequenceFile vs. Avro's DataFileWriter.

          I'll add hbase-default.xml entries on commit as J-D suggests.

          Show
          apurtell Andrew Purtell added a comment - Passes all local tests, importantly: TestFullLogReconstruction TestHLog I'd like to see this go in. It's the foundation for a bake off between different log formats, for example, SequenceFile vs. Avro's DataFileWriter. I'll add hbase-default.xml entries on commit as J-D suggests.
          Hide
          stack stack added a comment -

          +1 on the notion and on the patch.

          Show
          stack stack added a comment - +1 on the notion and on the patch.
          Hide
          apurtell Andrew Purtell added a comment -

          Committed to trunk.

          Show
          apurtell Andrew Purtell added a comment - Committed to trunk.
          Hide
          lars_francke Lars Francke added a comment -

          This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

          Show
          lars_francke Lars Francke added a comment - This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

            People

            • Assignee:
              apurtell Andrew Purtell
              Reporter:
              apurtell Andrew Purtell
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development