[HBASE-20543] Fix the flaky TestThriftHttpServer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 3.0.0-alpha-1, 2.1.0
• Hadoop Flags: Reviewed
• Assignee: Zheng Hu
• Reporter: Zheng Hu
• Created: 08/May/18 12:31
• Updated: 13/Dec/18 16:23
• Resolved: 09/May/18 02:59

Description

The runThriftServer() in TestThriftHttpServer, we have the following :

private void runThriftServer(int customHeaderSize) throws Exception {
//......
    startHttpServerThread(args.toArray(new String[args.size()]));

    // wait up to 10s for the server to start
    for (int i = 0; i < 100
        && (thriftServer.serverRunner == null ||  thriftServer.serverRunner.httpServer ==
        null); i++) {
      Thread.sleep(100);
    }
//......
      checkHttpMethods(url);
//......
}

The port may still not open even if the thriftServer.serverRunner != null and thriftServer.serverRunner.httpServer != null, so the checkHttpMethods will get a connection refused ...

We should wait till the port is really listening....