[HBASE-20507] Do not need to call recoverLease on the broken file when we fail to create a wal writer

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.1.0, 2.0.1
• Component/s: wal
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 29/Apr/18 11:59
• Updated: 31/May/18 05:33
• Resolved: 03/May/18 19:32

Description

I tried locally with a UT, if we overwrite a file which is currently being written, the old file will be completed and then deleted. If you call close on the previous file, a no lease exception will be thrown which means that the file has already been completed.

So we do not need to close a file if it will be overwritten immediately, since recoverLease may take a very long time...

Issue Links

• is related to: HBASE-20503 [AsyncFSWAL] Failed to get sync result after 300000 ms for txid=160912, WAL system stuck?