Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20507

Do not need to call recoverLease on the broken file when we fail to create a wal writer

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.1.0, 2.0.1
    • wal
    • None
    • Reviewed

    Description

      I tried locally with a UT, if we overwrite a file which is currently being written, the old file will be completed and then deleted. If you call close on the previous file, a no lease exception will be thrown which means that the file has already been completed.

      So we do not need to close a file if it will be overwritten immediately, since recoverLease may take a very long time...

      Attachments

        1. HBASE-20507.patch
          6 kB
          Duo Zhang
        2. 20507.addendum.patch
          1 kB
          Michael Stack

        Issue Links

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: