[HBASE-20400] Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 3.0.0-alpha-1, 1.5.0, 2.0.0-beta-1, 1.4.4, 2.0.0
• Component/s: master, Performance
• Assignee: Unassigned
• Reporter: Tak-Lon (Stephen) Wu
• Created: 12/Apr/18 18:38
• Updated: 13/Apr/18 06:09
• Resolved: 13/Apr/18 06:09

Description

When backporting HBASE-18309 in HBASE-20352, the deleteFiles calls

CleanerContext.java#getResult with a waitIfNotFinished timeout to wait for notification (notify) from the fs.delete file thread. there might be two situation need to tune the MAX_WAIT in CleanerContext or make a configuration property for waitIfNotFinished when LogClearner call getResult.

1. fs.delete never complete (strange but possible), then we need to wait for a max of 60 seconds. here, 60 seconds might be too long
2. getResult is waiting in the period of 500 milliseconds, but the fs.delete has completed and setFromClear is set but yet notify(). one might want to tune this 500 milliseconds to 200 or less .

Issue Links

• duplicates: HBASE-20401 Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable