[HBASE-20136] TestKeyValue misses ClassRule and Category annotations

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.2, 2.0.4
• Labels: CE
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 05/Mar/18 23:09
• Updated: 24/Dec/18 12:32
• Resolved: 23/Dec/18 18:20

Description

hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java misses ClassRule and Category annotations.

TestKeyValue was flagged by internal RE which used mvn command that is different from what Apache Jenkins uses.

mvn -B -nsu test -Dtest=TestKeyValue --projects :hbase-common

ArrayIndexOutOfBoundsException from HBaseClassTestRuleChecker was observed in snippet from dump file:

# Created on 2018-03-05T22:25:50.252
org.apache.maven.surefire.testset.TestSetFailedException: Test mechanism :: 0
	at org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:223)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:168)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:373)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:334)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:119)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:407)
Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
	at org.apache.hadoop.hbase.HBaseClassTestRuleChecker.testStarted(HBaseClassTestRuleChecker.java:45)
	at org.junit.runner.notification.RunNotifier$3.notifyListener(RunNotifier.java:121)
	at org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)
	at org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:118)

This issue adds the annotations to this test.
The test passes with annotations added.

I have searched code base but didn't find other test which misses test category.

Issue Links

• is duplicated by: HBASE-21637 TestCheckTestClasses is failing in branch-2
• relates to: HBASE-20154 Make sure all tests have a small/medium/large category
• links to: Review Board (branch-2)