[HBASE-20119] Introduce a pojo class to carry coprocessor information in order to make TableDescriptorBuilder accept multiple cp at once

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Incompatible change, Reviewed

Release Note

1) Make all methods in TableDescriptorBuilder be setter pattern.
addCoprocessor -> setCoprocessor
addColumnFamily -> setColumnFamily
(addCoprocessor and addColumnFamily are still in branch-2 but they are marked as deprecated)
2) add CoprocessorDescriptor to carry cp information
3) add CoprocessorDescriptorBuilder to build CoprocessorDescriptor
4) TD disallow user to set negative priority to coprocessor since parsing the negative value will cause a exception

• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 02/Mar/18 09:37
• Updated: 14/Aug/20 18:53
• Resolved: 19/Mar/18 01:21

Description

The way to add cp to TableDescriptorBuilder is shown below.

public TableDescriptorBuilder addCoprocessor(String className) throws IOException {
  return addCoprocessor(className, null, Coprocessor.PRIORITY_USER, null);
}

public TableDescriptorBuilder addCoprocessor(String className, Path jarFilePath,
        int priority, final Map<String, String> kvs) throws IOException {
  desc.addCoprocessor(className, jarFilePath, priority, kvs);
  return this;
}

public TableDescriptorBuilder addCoprocessorWithSpec(final String specStr) throws IOException {
  desc.addCoprocessorWithSpec(specStr);
  return this;
}

When loading our config to create table with multiple cps, we have to write the ugly for-loop.

val builder = TableDescriptorBuilder.newBuilde(tableName)
  .setAAA()
  .setBBB()
cps.map(toHBaseCp).foreach(builder.addCoprocessor)
cfs.map(toHBaseCf).foreach(builder.addColumnFamily)
admin.createTable(builder.build())

If we introduce a pojo to carry the cp data and add the method accepting multiple cps and cfs, it is easier to exercise the fluent interface of TableDescriptorBuilder.

admin.createTable(TableDescriptorBuilder.newBuilde(tableName)
.addCoprocessor(cps.map(toHBaseCp).asJavaCollection)
.addColumnFamily(cf.map(toHBaseCf).asJavaCollection)
.setAAA()
.setBBB()
.build)

 

 

Issue Links

• relates to: HBASE-18776 Update coprocessor docs after HBASE-17732
• links to: Review Board