Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20051

Correct usage statement of endtime for VerifyReplication

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 1.2.0, 1.3.0, 1.2.1, 1.2.2, 1.3.1, 1.2.3, 1.2.4, 1.2.5, 1.2.6
    • 1.3.2, 1.2.7
    • Replication
    • None

    Description

      VerifyReplication's usage claims that --stoptime will give end of time range, but then parses --endtime.

      Not an issue on branches that already have HBASE-16772, because it fixed the usage as a side effect.

      Attachments

        Activity

          elserj Josh Elser added a comment -

          +1

          elserj Josh Elser added a comment - +1
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-1.3 Compile Tests
          +1 mvninstall 7m 42s branch-1.3 passed
          +1 compile 0m 34s branch-1.3 passed with JDK v1.8.0_162
          +1 compile 0m 37s branch-1.3 passed with JDK v1.7.0_171
          +1 checkstyle 1m 20s branch-1.3 passed
          +1 shadedjars 3m 50s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 1m 53s branch-1.3 passed
          +1 javadoc 0m 32s branch-1.3 passed with JDK v1.8.0_162
          +1 javadoc 0m 34s branch-1.3 passed with JDK v1.7.0_171
                Patch Compile Tests
          +1 mvninstall 1m 28s the patch passed
          +1 compile 0m 32s the patch passed with JDK v1.8.0_162
          +1 javac 0m 32s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.7.0_171
          +1 javac 0m 35s the patch passed
          +1 checkstyle 1m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 2m 23s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 8m 24s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.4.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0_162
          +1 javadoc 0m 35s the patch passed with JDK v1.7.0_171
                Other Tests
          -1 unit 88m 54s hbase-server in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          121m 10s



          Reason Tests
          Failed junit tests hadoop.hbase.regionserver.TestEndToEndSplitTransaction
            hadoop.hbase.util.TestHBaseFsck



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:dca6535
          JIRA Issue HBASE-20051
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12911569/HBASE-20051-branch-1.3.v0.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux 8e3af6e5e9f9 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision branch-1.3 / 149ebf3
          maven version: Apache Maven 3.0.5
          Default Java 1.7.0_171
          Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_162 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_171
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/11618/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11618/testReport/
          Max. process+thread count 3784 (vs. ulimit of 10000)
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11618/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-1.3 Compile Tests +1 mvninstall 7m 42s branch-1.3 passed +1 compile 0m 34s branch-1.3 passed with JDK v1.8.0_162 +1 compile 0m 37s branch-1.3 passed with JDK v1.7.0_171 +1 checkstyle 1m 20s branch-1.3 passed +1 shadedjars 3m 50s branch has no errors when building our shaded downstream artifacts. +1 findbugs 1m 53s branch-1.3 passed +1 javadoc 0m 32s branch-1.3 passed with JDK v1.8.0_162 +1 javadoc 0m 34s branch-1.3 passed with JDK v1.7.0_171       Patch Compile Tests +1 mvninstall 1m 28s the patch passed +1 compile 0m 32s the patch passed with JDK v1.8.0_162 +1 javac 0m 32s the patch passed +1 compile 0m 35s the patch passed with JDK v1.7.0_171 +1 javac 0m 35s the patch passed +1 checkstyle 1m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 2m 23s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 8m 24s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.4. +1 findbugs 2m 11s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0_162 +1 javadoc 0m 35s the patch passed with JDK v1.7.0_171       Other Tests -1 unit 88m 54s hbase-server in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 121m 10s Reason Tests Failed junit tests hadoop.hbase.regionserver.TestEndToEndSplitTransaction   hadoop.hbase.util.TestHBaseFsck Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:dca6535 JIRA Issue HBASE-20051 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12911569/HBASE-20051-branch-1.3.v0.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 8e3af6e5e9f9 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-1.3 / 149ebf3 maven version: Apache Maven 3.0.5 Default Java 1.7.0_171 Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_162 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_171 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/11618/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11618/testReport/ Max. process+thread count 3784 (vs. ulimit of 10000) modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11618/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.
          busbey Sean Busbey added a comment -

          > -1 test4tests

          We don't have tests for CLI help messages, AFAICT. Would like to ignore this one.

          > -1 unit 88m 54s hbase-server in the patch failed.
          > Failed junit tests hadoop.hbase.regionserver.TestEndToEndSplitTransaction
          > hadoop.hbase.util.TestHBaseFsck

          I don't see how either of these could be failing due to my change and reading the test output doesn't seem to point at VerifyReplication at all. Unfortunately we don't have a flakey dashboard for maintenance branches, but I see TestEndToEndSplitTransaction failed in nightly for branch-1.3 last night.

          Fine with going forward still elserj?

          busbey Sean Busbey added a comment - > -1 test4tests We don't have tests for CLI help messages, AFAICT. Would like to ignore this one. > -1 unit 88m 54s hbase-server in the patch failed. > Failed junit tests hadoop.hbase.regionserver.TestEndToEndSplitTransaction > hadoop.hbase.util.TestHBaseFsck I don't see how either of these could be failing due to my change and reading the test output doesn't seem to point at VerifyReplication at all. Unfortunately we don't have a flakey dashboard for maintenance branches, but I see TestEndToEndSplitTransaction failed in nightly for branch-1.3 last night. Fine with going forward still elserj ?
          psomogyi Peter Somogyi added a comment -

          +1

          psomogyi Peter Somogyi added a comment - +1
          elserj Josh Elser added a comment -

          No qualms from me.

          elserj Josh Elser added a comment - No qualms from me.
          busbey Sean Busbey added a comment -

          awesome. thanks to you both for the reviews!

          busbey Sean Busbey added a comment - awesome. thanks to you both for the reviews!
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.3-IT #356 (See https://builds.apache.org/job/HBase-1.3-IT/356/)
          HBASE-20051 Correct usage statement of endtime for VerifyReplication (busbey: rev a7a7577912482709edf63dfa698dedb1e12639a4)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.3-IT #356 (See https://builds.apache.org/job/HBase-1.3-IT/356/ ) HBASE-20051 Correct usage statement of endtime for VerifyReplication (busbey: rev a7a7577912482709edf63dfa698dedb1e12639a4) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1072 (See https://builds.apache.org/job/HBase-1.2-IT/1072/)
          HBASE-20051 Correct usage statement of endtime for VerifyReplication (busbey: rev 42c75d418270fe8fc834285bbbd7264af91bc035)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1072 (See https://builds.apache.org/job/HBase-1.2-IT/1072/ ) HBASE-20051 Correct usage statement of endtime for VerifyReplication (busbey: rev 42c75d418270fe8fc834285bbbd7264af91bc035) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java

          People

            busbey Sean Busbey
            busbey Sean Busbey
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: