[HBASE-19953] Avoid calling post* hook when procedure fails

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-2, 2.0.0
• Component/s: master, proc-v2
• Hadoop Flags: Reviewed
• Assignee: Josh Elser
• Reporter: Ramesh Mani
• Created: 07/Feb/18 19:47
• Updated: 14/May/20 08:11
• Resolved: 21/Feb/18 19:21

Description

Ramesh pointed out a case where I think we're mishandling some post* MasterObserver hooks. Specifically, I'm looking at the deleteNamespace.

We synchronously execute the DeleteNamespace procedure. When the user provides a namespace that isn't empty, the procedure does a rollback (which is just a no-op), but this doesn't propagate an exception up to the NonceProcedureRunnable in HMaster#deleteNamespace. It took Ramesh pointing it out a bit better to me that the code executes a bit differently than we actually expect.

I think we need to double-check our post hooks and make sure we aren't invoking them when the procedure actually failed. cc/ Apache9, stack.

Issue Links

• is related to: HBASE-21469 Re-visit post* hooks in DDL operations
• is related to: HBASE-24372 Assign table to default RSGroup may throw exception when RSGroup enabled
• relates to: HBASE-20658 Release latch early for ModifyTable and TruncateTable procedure.